Skip to content

Fix: handle undefined binding.size to prevent NaN -fixes #262 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shriya-gatate wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: handle undefined binding.size to prevent NaN -fixes #262 #266

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d00b8e
Fix: handle undefined binding.size to prevent NaN -fixes #262
Jun 28, 2026
d606ef1
fix: null check for binding.size in file-browser
Jul 7, 2026
6cdf54a
fix: safe null check for binding.size using local variable
Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/js/components/file-browser/file-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function FileBrowserController($http, $scope) {

for (var b in ctrl.queryResult.bindings) {
var binding = ctrl.queryResult.bindings[b];
binding.size.numericalValue = parseInt(binding.size.value);
binding.size.numericalValue = binding.size? parseInt(binding.size.value):0;
ctrl.queryResult.uriList += binding.file.value + "\n";

if (binding.variant != undefined) {
Expand All @@ -142,7 +142,7 @@ function FileBrowserController($http, $scope) {



ctrl.totalSize += binding.size.numericalValue;
ctrl.totalSize += binding.size?binding.size.numericalValue:0;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
ctrl.numFiles++;
}

Expand Down