Skip to content

Wait for the sender before checking its status in NotificationServiceTest #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devhawk merged 1 commit into from
Oct 20, 2026
Merged

Wait for the sender before checking its status in NotificationServiceTest #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions transact/src/test/java/dev/dbos/transact/notifications/NotificationServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ public void basic_send_recv() throws Exception {

String result = (String) handle1.getResult();
assertEquals("HelloDBOS", result);
// The receiver can finish as soon as the send step commits, before the sender records SUCCESS.
handle2.getResult();

assertEquals(WorkflowState.SUCCESS, handle1.getStatus().status());
assertEquals(WorkflowState.SUCCESS, handle2.getStatus().status());
Expand Down Expand Up @@ -271,6 +273,8 @@ public void notopic() throws Exception {

String result = (String) handle1.getResult();
assertEquals("HelloDBOS", result);
// The receiver can finish as soon as the send step commits, before the sender records SUCCESS.
handle2.getResult();

assertEquals(WorkflowState.SUCCESS, handle1.getStatus().status());
assertEquals(WorkflowState.SUCCESS, handle2.getStatus().status());
Expand Down Expand Up @@ -333,6 +337,8 @@ public void sendNull() throws Exception {

String result = (String) handle1.getResult();
assertNull(result);
// The receiver can finish as soon as the send step commits, before the sender records SUCCESS.
handle2.getResult();

assertEquals(WorkflowState.SUCCESS, handle1.getStatus().status());
assertEquals(WorkflowState.SUCCESS, handle2.getStatus().status());
Expand Down Expand Up @@ -422,6 +428,8 @@ public void recvSleep() throws Exception {

String result = (String) handle1.getResult();
assertEquals("HelloDBOS", result);
// The receiver can finish as soon as the send step commits, before the sender records SUCCESS.
handle2.getResult();

assertEquals(WorkflowState.SUCCESS, handle1.getStatus().status());
assertEquals(WorkflowState.SUCCESS, handle2.getStatus().status());
Expand Down
Loading