Repository navigation
Remove dead code and run testInsertWorkflowStatusValidation - #598
Merged
Merged
Conversation
Delete members with no references in any module, main or test: - StepResult.withOutput, withError, ofError - DBOSIntegration.RegisteredWorkflowConsumer - DebugTriggers sleep and semaphore actions, which nothing set, and the hit-count bookkeeping (DebugPoint, CallSiteInfo, getPointLocationsSnapshot, releaseDebugTrigger), which nothing read - SerializationUtil.safeParse, safeParseArgs, safeParseError - Constants.SYS_DB_SUFFIX, POSTGRES_DEFAULT_DB - DBOSAspect.getMethodName - DBOSContext.getStepId, getTimeout, getNextDeadline, getDeadline, and the timeout field that only getTimeout read - Test helpers DBUtils.clearTables, closeDS, dumpResultSet, and the two delete helpers only clearTables called testInsertWorkflowStatusValidation had no @test annotation and never ran. Annotate it; it passes.
kraftp
approved these changes
Oct 1, 2026
devhawk
added a commit
that referenced
this pull request
Oct 1, 2026
The `test-demo-apps` matrix jobs ran without `setup-gradle`. Each one downloaded the Gradle distribution and the full Spring Boot dependency tree from Maven Central on every run, and they have failed several times on `429 Too Many Requests` (e.g. the widget-store job on #598). - Add `gradle/actions/setup-gradle@v5` to the `test-demo-apps` job, matching `test.yml` and the `publish` job. - Run the demo-app tests on pushes to `main`. `setup-gradle` only writes its cache on the default branch, and each job restores only its own cache. Without a `main` run, PR runs would have nothing to restore. The `main` run is a separate job; `publish` does not depend on it. PRs pick up the cache after the first push to `main` with this change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes code that has no references in any module, main or test, and turns on a test that never ran.
Removed
StepResult.withOutput,withError,ofErrorDBOSIntegration.RegisteredWorkflowConsumer. Unused since Update WF registration API #382 replaced the registration callback withWorkflowRegistry.DebugTriggers: the sleep and semaphore actions, which nothing set, and the hit-count bookkeeping (DebugPoint,CallSiteInfo,getPointLocationsSnapshot,releaseDebugTrigger), which nothing read.debugTriggerPointnow runs the callback and throws the configuredSQLException, the only two actions any test uses.SerializationUtil.safeParse,safeParseArgs,safeParseErrorConstants.SYS_DB_SUFFIX,POSTGRES_DEFAULT_DBDBOSAspect.getMethodNameDBOSContext.getStepId,getTimeout,getNextDeadline,getDeadline. Also removes thetimeoutfield, which onlygetTimeoutread, and its constructor parameter.DBUtils.clearTables,closeDS,dumpResultSet, and the two delete helpers that onlyclearTablescalled.Constants,SerializationUtilandDBOSContextare SDK internals, not public API, so these go without a deprecation release.Test fix
SystemDatabaseTest.testInsertWorkflowStatusValidationhas had no@Testannotation since it was added in #339, so it never ran. It now has one, and it passes.Testing
spotlessCheck,compileTestJava,:transact:javadocand PMD pass.SystemDatabaseTest.testInsertWorkflowStatus*tests pass (7).SingleExecutionTest,DebouncerTestandDebouncerClientTest, the classes that set debug triggers, pass (80).🤖 Generated with Claude Code