Skip to content

docs: search is no longer beta - #12

Merged
datalegion-jack merged 3 commits into
mainfrom
docs/search-not-beta
Nov 6, 2026
Merged

datalegion-jack merged 3 commits into
mainfrom
docs/search-not-beta

Conversation

@datalegion-jack

Copy link
Copy Markdown
Contributor

What

Person and company search are generally available. This drops "(Beta)" from:

  • README.md: the "Person search" and "Company search" headings.
  • datalegion-cli person search --help and datalegion-cli company search --help (the command docstrings).

Discover stays in beta.

Checks

  • pytest: 171 passed, including the 10 live tests against the production API.
  • ruff check: clean.
  • Help text checked by running both commands with --help.

Dependencies

  • uv lock --upgrade: pydantic 2.14.2 -> 2.14.3, pydantic-core 2.50.2 -> 2.50.4, typer 0.27.3 -> 0.28.0, ruff 0.17.3 -> 0.17.4, typing-inspection 0.4.4 -> 0.4.5; tests pass on the new lock.
  • osv-scanner on uv.lock: no issues.

🤖 Generated with Claude Code

Person and company search are generally available: drop "(Beta)" from the
README headings and the `person search` / `company search` help text.
Discover stays in beta. Also refreshes the lock (pydantic 2.14.3, typer 0.28.0,
ruff 0.17.4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@datalegion-jack
datalegion-jack requested a review from a team as a code owner November 6, 2026 14:51

@datalegion-jack datalegion-jack left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at e72dc73 (base 179a927 = origin/main). No defects found.

Checks run locally

  • uv sync --frozen, uv lock --check: clean (lock matches pyproject.toml).
  • uv run pytest -q -rs: 161 passed, 10 skipped (tests/test_live.py, no DATALEGION_API_KEY set in this run, as expected). I could not re-run the body's "10 live tests against production" claim without a key. CI is green on 3.11 through 3.15.
  • uv run ruff check .: all checks passed. ruff format --check: 28 files already formatted.
  • osv-scanner scan --lockfile uv.lock: no issues.

typer 0.27.3 -> 0.28.0: output compared with main
I captured --help for datalegion-cli, person, company, utility, and the subcommands person/company search|enrich|discover, utility clean|hash|validate|report and credits balance|usage. I ran each at COLUMNS=120 and NO_COLOR=1, once in a clean clone of main (typer 0.27.3) and once on this branch (typer 0.28.0). Then I diffed the two sets. The only differences are the two intended lines:

< Search for people with a SQL SELECT over the people table, no LIMIT (Beta).
> Search for people with a SQL SELECT over the people table, no LIMIT.
< Search for companies with a SQL SELECT over the companies table, no LIMIT (Beta).
> Search for companies with a SQL SELECT over the companies table, no LIMIT.

Argument parsing behaves the same on both versions. I tested a missing query argument, --limit abc ("'abc' is not a valid int"), an unknown option --bogus, and utility hash a@b.com. The output was byte-identical between main and this branch.

Leftover "beta" mentions (git grep -i beta, excluding uv.lock)

  • README.md:147, README.md:174, src/datalegion_cli/commands/person.py:171 and src/datalegion_cli/commands/company.py:146 are all about discover, which stays in beta as intended. person discover --help and company discover --help still say "(Beta)".
  • pyproject.toml:20 has Development Status :: 4 - Beta. This is the package-maturity trove classifier and has nothing to do with the search endpoints, so it is correct to leave it unchanged.
  • Nothing else in the repo calls search beta.

PR body accuracy
The version pairs listed (pydantic 2.14.2->2.14.3, pydantic-core 2.50.2->2.50.4, typer 0.27.3->0.28.0, ruff 0.17.3->0.17.4, typing-inspection 0.4.4->0.4.5) match the uv.lock diff exactly. Nothing else changed in the lock.

Public repo
The diff and the body contain no internal names, hostnames or agent files. The Claude Code footer and co-author line follow the convention of the earlier merged PRs here (#8, #9, #10).

Not a blocker: the help-text change only reaches users with the next CLI release. This PR does not bump the version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@datalegion-jack

Copy link
Copy Markdown
Contributor Author

Re-review of the delta e72dc73..8a40218 (docs: title-case README headings and product names). No defects found.

Scope. git diff e72dc734 8a40218 --stat shows a single file, README.md (16+/16-). The changes are 15 headings plus the sandbox sentence at README.md:242. No code, lock or config changed. CI is green on the new head: lint, actionlint, tests on 3.11 through 3.15, and CodeQL.

Headings. Every #/##/### heading in the file is now Title Case. "(Beta)" stays on the two Discovery headings (README.md:147, README.md:174). "PyPI" and "GitHub" keep their casing, and "or" stays lowercase in README.md:30. The # lines inside fenced bash blocks are shell comments, not headings, and they were correctly left alone. The markup is plain ATX, so nothing changes in how the headings render.

Anchors. GitHub and PyPI build heading slugs from lowercased text, so Title Case leaves every #anchor unchanged (for example, #person-search and #from-github-release). I also grepped this repo, web/ (including docs and content) and the rest of the local fleet for datalegion-cli#, datalegion-cli/blob/...# and README.md#. There are no inbound links to any anchor in this README.

Nit, not blocking: in README.md:242, the first sentence now capitalizes "Discover" as a product name, but the third sentence still says "Sandbox discover answers only a few fixed example queries". You could make that "Sandbox Discover" for consistency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@datalegion-jack datalegion-jack left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review round 2 at 76b1b66. Since the approval at 8a40218, the only new commit is 76b1b66. Verdict: approve.

76b1b66: the README.md:133 comment "Multiple results with minimum confidence" becomes "Minimum confidence". That's correct: the example underneath runs only --min-confidence high, and the CLI's person enrich / company enrich have no multiple-results or --limit option (LimitOpt is used only by search / discover, commands/person.py:132, 166, commands/company.py:106, 141). Nothing else in the README or src/ mentions multiple results.

Note, no change asked: the body still describes the "Person search" / "Company search" headings in their old casing and doesn't mention the title-casing commit (8a40218) or this one. It's cosmetic, so update it if you touch the body.

Checks, re-run locally at 76b1b66: uv sync --frozen OK; uv run pytest -q -rs with DATALEGION_API_KEY set: 171 passed, no skips (the 10 live tests ran against production); ruff check and ruff format --check: clean. CI is green on this head. No internal names or agent references in the diff or the body.

@datalegion-jack
datalegion-jack merged commit 903e3fd into main Nov 6, 2026
11 checks passed
@datalegion-jack
datalegion-jack deleted the docs/search-not-beta branch November 6, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant