Repository navigation
docs: search is no longer beta - #12
Conversation
Person and company search are generally available: drop "(Beta)" from the README headings and the `person search` / `company search` help text. Discover stays in beta. Also refreshes the lock (pydantic 2.14.3, typer 0.28.0, ruff 0.17.4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
datalegion-jack
left a comment
There was a problem hiding this comment.
Review at e72dc73 (base 179a927 = origin/main). No defects found.
Checks run locally
uv sync --frozen,uv lock --check: clean (lock matchespyproject.toml).uv run pytest -q -rs: 161 passed, 10 skipped (tests/test_live.py, noDATALEGION_API_KEYset in this run, as expected). I could not re-run the body's "10 live tests against production" claim without a key. CI is green on 3.11 through 3.15.uv run ruff check .: all checks passed.ruff format --check: 28 files already formatted.osv-scanner scan --lockfile uv.lock: no issues.
typer 0.27.3 -> 0.28.0: output compared with main
I captured --help for datalegion-cli, person, company, utility, and the subcommands person/company search|enrich|discover, utility clean|hash|validate|report and credits balance|usage. I ran each at COLUMNS=120 and NO_COLOR=1, once in a clean clone of main (typer 0.27.3) and once on this branch (typer 0.28.0). Then I diffed the two sets. The only differences are the two intended lines:
< Search for people with a SQL SELECT over the people table, no LIMIT (Beta).
> Search for people with a SQL SELECT over the people table, no LIMIT.
< Search for companies with a SQL SELECT over the companies table, no LIMIT (Beta).
> Search for companies with a SQL SELECT over the companies table, no LIMIT.
Argument parsing behaves the same on both versions. I tested a missing query argument, --limit abc ("'abc' is not a valid int"), an unknown option --bogus, and utility hash a@b.com. The output was byte-identical between main and this branch.
Leftover "beta" mentions (git grep -i beta, excluding uv.lock)
README.md:147,README.md:174,src/datalegion_cli/commands/person.py:171andsrc/datalegion_cli/commands/company.py:146are all about discover, which stays in beta as intended.person discover --helpandcompany discover --helpstill say "(Beta)".pyproject.toml:20hasDevelopment Status :: 4 - Beta. This is the package-maturity trove classifier and has nothing to do with the search endpoints, so it is correct to leave it unchanged.- Nothing else in the repo calls search beta.
PR body accuracy
The version pairs listed (pydantic 2.14.2->2.14.3, pydantic-core 2.50.2->2.50.4, typer 0.27.3->0.28.0, ruff 0.17.3->0.17.4, typing-inspection 0.4.4->0.4.5) match the uv.lock diff exactly. Nothing else changed in the lock.
Public repo
The diff and the body contain no internal names, hostnames or agent files. The Claude Code footer and co-author line follow the convention of the earlier merged PRs here (#8, #9, #10).
Not a blocker: the help-text change only reaches users with the next CLI release. This PR does not bump the version.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re-review of the delta e72dc73..8a40218 ( Scope. Headings. Every Anchors. GitHub and PyPI build heading slugs from lowercased text, so Title Case leaves every Nit, not blocking: in |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
datalegion-jack
left a comment
There was a problem hiding this comment.
Review round 2 at 76b1b66. Since the approval at 8a40218, the only new commit is 76b1b66. Verdict: approve.
76b1b66: the README.md:133 comment "Multiple results with minimum confidence" becomes "Minimum confidence". That's correct: the example underneath runs only --min-confidence high, and the CLI's person enrich / company enrich have no multiple-results or --limit option (LimitOpt is used only by search / discover, commands/person.py:132, 166, commands/company.py:106, 141). Nothing else in the README or src/ mentions multiple results.
Note, no change asked: the body still describes the "Person search" / "Company search" headings in their old casing and doesn't mention the title-casing commit (8a40218) or this one. It's cosmetic, so update it if you touch the body.
Checks, re-run locally at 76b1b66: uv sync --frozen OK; uv run pytest -q -rs with DATALEGION_API_KEY set: 171 passed, no skips (the 10 live tests ran against production); ruff check and ruff format --check: clean. CI is green on this head. No internal names or agent references in the diff or the body.
What
Person and company search are generally available. This drops "(Beta)" from:
README.md: the "Person search" and "Company search" headings.datalegion-cli person search --helpanddatalegion-cli company search --help(the command docstrings).Discover stays in beta.
Checks
pytest: 171 passed, including the 10 live tests against the production API.ruff check: clean.--help.Dependencies
uv lock --upgrade: pydantic 2.14.2 -> 2.14.3, pydantic-core 2.50.2 -> 2.50.4, typer 0.27.3 -> 0.28.0, ruff 0.17.3 -> 0.17.4, typing-inspection 0.4.4 -> 0.4.5; tests pass on the new lock.osv-scanneronuv.lock: no issues.🤖 Generated with Claude Code