-
Notifications
You must be signed in to change notification settings - Fork 202
feat: 🎸 add bigquery option of with connection #1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
f796515
f069821
cc443a7
f22de26
6c9e4b8
8454e3d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,11 @@ export interface IBigQueryOptions { | |
| */ | ||
| requirePartitionFilter?: boolean; | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| withConnection?: string; | ||
|
|
||
| /** | ||
| * Key-value pairs for options [table](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#table_option_list), [view](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#view_option_list), [materialized view](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#materialized_view_option_list). | ||
| * | ||
|
|
@@ -114,6 +119,7 @@ const IBigQueryOptionsProperties = () => | |
| "labels", | ||
| "partitionExpirationDays", | ||
| "requirePartitionFilter", | ||
| "withConnection", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @Ekrekr ! For reference, the following commands were successful: bazel build cli
bazel test //core/...
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not your fault - we have a couple issues with our CI/CD which we're resolving currently. I'll get this PR in once we've managed to fix them!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the clarification! I understand the issue is on the CI/CD side. Please let me know if there's anything I can do to help in the meantime. I’ll wait for the fix and look forward to the PR being merged. Thanks again for your support! |
||
| "additionalOptions" | ||
| ]); | ||
|
|
||
|
|
@@ -319,6 +325,7 @@ export class Table extends ActionBuilder<dataform.Table> { | |
| config.requirePartitionFilter || | ||
| config.clusterBy.length || | ||
| Object.keys(config.labels).length || | ||
| config.withConnection || | ||
| Object.keys(config.additionalOptions).length | ||
| ? {} | ||
| : undefined; | ||
|
|
@@ -338,6 +345,9 @@ export class Table extends ActionBuilder<dataform.Table> { | |
| if (Object.keys(config.labels).length) { | ||
| bigqueryOptions.labels = config.labels; | ||
| } | ||
| if (config.withConnection) { | ||
| bigqueryOptions.withConnection = config.withConnection; | ||
| } | ||
| if (Object.keys(config.additionalOptions).length) { | ||
| bigqueryOptions.additionalOptions = config.additionalOptions; | ||
| } | ||
|
|
@@ -402,6 +412,7 @@ export class Table extends ActionBuilder<dataform.Table> { | |
| config.updatePartitionFilter || | ||
| config.clusterBy.length || | ||
| Object.keys(config.labels).length || | ||
| config.withConnection || | ||
| Object.keys(config.additionalOptions).length | ||
| ? {} | ||
| : undefined; | ||
|
|
@@ -421,6 +432,9 @@ export class Table extends ActionBuilder<dataform.Table> { | |
| if (config.clusterBy.length) { | ||
| bigqueryOptions.clusterBy = config.clusterBy; | ||
| } | ||
| if (config.withConnection) { | ||
| bigqueryOptions.withConnection = config.withConnection | ||
| } | ||
| if (Object.keys(config.labels).length) { | ||
| bigqueryOptions.labels = config.labels; | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.