Skip to content

test(consensus): deflake TestWALRoundsSkipper #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lklimek merged 3 commits into from
Sep 14, 2026
+26 −3
Merged

test(consensus): deflake TestWALRoundsSkipper #1457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cb69e4
test(consensus): deflake TestWALRoundsSkipper
lklimek Sep 11, 2026
1405fe2
test(consensus): wait for WAL replay writes before cleanup
lklimek Sep 14, 2026
e13e9e4
chore: merge v1.8-dev into WAL rounds skipper fix
lklimek Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions internal/consensus/replay_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,15 +1495,37 @@ func testWALRoundsSkipper(t *testing.T, slowProposer bool) {
require.NoError(t, err)
ctx = dash.ContextWithProTxHash(ctx, proTxHash)

cs := newStateWithConfigAndBlockStore(ctx, t, logger, cfg, state, privVal, app, blockStore)
stopReplay := make(chan struct{})
replayStopped := make(chan struct{})
cs := newStateWithConfigAndBlockStore(ctx, t, logger, cfg, state, privVal, app, blockStore,
WithStopFunc(func(cs *State) bool {
select {
case <-stopReplay:
default:
if cs.GetStateData().Height < chainLen+2 {
return false
}
}
close(replayStopped)
return true
}),
)

commit := blockStore.commits[len(blockStore.commits)-1]
require.Equal(t, int64(4), commit.Height)
require.GreaterOrEqual(t, maxRound, commit.Round)

require.NoError(t, cs.Start(ctx))
defer cs.Stop()
t.Cleanup(cs.Wait)
defer func() {
close(stopReplay)
<-replayStopped
cs.Stop()
cs.Wait()
// The stop predicate bypasses receiveRoutine's WAL and queue shutdown.
cs.wal.Stop()
cs.wal.Wait()
cs.msgInfoQueue.stop()
}()

newBlockSub, err := cs.eventBus.SubscribeWithArgs(ctx, pubsub.SubscribeArgs{
ClientID: testSubscriber,
Expand All @@ -1516,6 +1538,7 @@ func testWALRoundsSkipper(t *testing.T, slowProposer bool) {
require.NoError(t, err)
eventNewBlock := msg.Data().(types.EventDataNewBlock)
require.Equal(t, chainLen+1, eventNewBlock.Block.Height)
<-replayStopped
commit = blockStore.commits[chainLen-1]
require.Equal(t, chainLen, commit.Height)
require.GreaterOrEqual(t, maxRound, commit.Round)
Expand Down
Loading