Skip to content

fix(dash-spv): persist masternode list - #990

Open
ZocoLini wants to merge 3 commits into
devfrom
fix/persist-masternode-list
Open

fix(dash-spv): persist masternode list#990
ZocoLini wants to merge 3 commits into
devfrom
fix/persist-masternode-list

refactor(dash-spv): let the storage own the masternode state format

a413afd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 27, 2026 in 0s

77.14% (+0.00%) compared to 237f79a

View this Pull Request on Codecov

77.14% (+0.00%) compared to 237f79a

Details

Codecov Report

❌ Patch coverage is 61.81818% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.14%. Comparing base (237f79a) to head (a413afd).

Files with missing lines Patch % Lines
dash-spv/src/storage/masternode.rs 17.64% 14 Missing ⚠️
dash-spv/src/client/lifecycle.rs 62.50% 3 Missing ⚠️
dash-spv/src/storage/mod.rs 60.00% 2 Missing ⚠️
dash-spv/src/sync/masternodes/manager.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #990   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files         329      329           
  Lines       82998    83039   +41     
=======================================
+ Hits        64026    64060   +34     
- Misses      18972    18979    +7     
Files with missing lines Coverage Δ
dash-spv/src/sync/masternodes/sync_manager.rs 88.61% <100.00%> (+0.10%) ⬆️
dash-spv/src/storage/mod.rs 85.24% <60.00%> (+0.13%) ⬆️
dash-spv/src/sync/masternodes/manager.rs 94.54% <88.88%> (-0.21%) ⬇️
dash-spv/src/client/lifecycle.rs 91.00% <62.50%> (-1.31%) ⬇️
dash-spv/src/storage/masternode.rs 27.27% <17.64%> (+7.27%) ⬆️

... and 3 files with indirect coverage changes