Skip to content

fix(dashmate): use live Tenderdash app version for protocol status #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thepastaclaw wants to merge 9 commits into
base: v4.2-dev
Choose a base branch
from
+216 −6
Open

fix(dashmate): use live Tenderdash app version for protocol status #4136

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
67e6cbf
fix(dashmate): use live Tenderdash app version for protocol status
thepastaclaw Jul 16, 2026
5542624
test(dashmate): fold protocol-version regression into happy-path fixture
thepastaclaw Jul 16, 2026
592b882
fix(dashmate): fall back when Tenderdash omits application_info
thepastaclaw Jul 16, 2026
6ec6a4c
fix(dashmate): source active protocol from consensus params
thepastaclaw Jul 27, 2026
8cd712d
test(dashmate): deduplicate protocol-version fallback tests
PastaPastaPasta Aug 23, 2026
a5144b0
refactor(dashmate): parse only the unwrapped Tenderdash RPC response …
PastaPastaPasta Aug 23, 2026
6124e96
fix(dashmate): reject partially numeric protocol-version values
PastaPastaPasta Aug 24, 2026
96314f7
style(dashmate): drop unrelated destructuring reformat
PastaPastaPasta Aug 24, 2026
0f55c13
docs(dashmate): make protocol-version test comment local to the mock
PastaPastaPasta Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/dashmate/src/status/scopes/platform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@ export default function getPlatformScopeFactory(
}

info.version = version;
info.protocolVersion = parseInt(tenderdashStatus.node_info.protocol_version.app, 10);
// node_info.protocol_version.app is snapshotted at Tenderdash process start and
// stays stale across in-process protocol upgrades. application_info.version is
// the live active/current app protocol version.
info.protocolVersion = parseInt(tenderdashStatus.application_info.version, 10);
// abci_info app_version reflects the installed software's desired/supported version.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
info.desiredProtocolVersion = tenderdashAbciInfo.response.app_version;
info.listening = listening;
info.latestBlockHeight = latestBlockHeight;
Expand Down
13 changes: 12 additions & 1 deletion packages/dashmate/test/unit/status/scopes/platform.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,22 @@ describe('getPlatformScopeFactory', () => {
mockDockerCompose.execCommand.withArgs(config, 'drive_abci', 'drive-abci version').resolves({ exitCode: 0, out: '1.4.1' });
mockMNOWatchProvider.returns(Promise.resolve('OPEN'));

// node_info.protocol_version.app can be stale after in-process upgrades;
// protocolVersion must come from application_info.version (live).
const mockStatus = {
node_info: {
protocol_version: {
p2p: '10',
block: '14',
app: '3',
app: '11',
},
version: '0',
network: 'test',
moniker: 'test',
},
application_info: {
version: '3',
},
sync_info: {
catching_up: false,
latest_app_hash: 'DEADBEEF',
Expand Down Expand Up @@ -182,6 +187,9 @@ describe('getPlatformScopeFactory', () => {
network: 'test',
moniker: 'test',
},
application_info: {
version: '3',
},
sync_info: {
catching_up: true,
latest_app_hash: 'DEADBEEF',
Expand Down Expand Up @@ -445,6 +453,9 @@ describe('getPlatformScopeFactory', () => {
network: 'test',
moniker: 'test',
},
application_info: {
version: '3',
},
sync_info: {
catching_up: false,
latest_app_hash: 'DEADBEEF',
Expand Down
Loading