Support dartpy with nanobind 3 - #3452
Merged
Merged
Conversation
Signed-off-by: Jeongseok Lee <jslee02@gmail.com>
…atibility Signed-off-by: Jeongseok Lee <jslee02@gmail.com>
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3452 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 667 667
Lines 92082 92082
=======================================
+ Hits 75209 75210 +1
+ Misses 16873 16872 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation / Problem
Changes / Key Changes
Testing
pixi run lintpixi run test-all(nanobind 2.14.0)pixi run -e cuda test-allpixi run -e py314-wheel wheel-build(isolated build resolved nanobind 3.0.0)pixi run -e py314-wheel wheel-verifypixi run -e py314-wheel wheel-testf9bf1363ec88f9501e1d2c3d0bcd0e8b37946f43e4401de9d36ffa1d2d557c1fwheel-repaircannot relabel this host-built artifact because the host emits newer glibc/GCC symbols; the hosted wheel workflow is the authoritative manylinux repair check.Breaking Changes
Related Issues / PRs (backports)
Checklist
main, branch-matching DART 6.x release milestone for the active DART 6 LTS branch)docs/onboarding/changelog.mdif required