[string_scanner] Extract LineScannerMixin and deduplicate eager scann… - #2569
Open
amanmaurya92 wants to merge 4 commits into
Open
[string_scanner] Extract LineScannerMixin and deduplicate eager scann…#2569amanmaurya92 wants to merge 4 commits into
amanmaurya92 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the line and column tracking logic by introducing a new LineScannerMixin on StringScanner. This mixin is then used by both LineScanner and EagerSpanScanner, successfully eliminating a significant amount of duplicated code. The feedback suggests adding a code example to the documentation of the newly introduced public LineScannerMixin to comply with the repository's style guide.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
LineScannerandEagerSpanScannerinpackage:string_scannerto share eager line and column tracking implementation viaLineScannerMixin:position=setter logic,_adjustLineAndColumn,scanChar,readChar, andscanintomixin LineScannerMixin on StringScanner.EagerSpanScannerto usewith LineScannerMixin, eliminating ~120 lines of duplicate regex-based state tracking and removing the legacyTODO(nweiz)trackingsdk#23770.pkgs/string_scanner/CHANGELOG.md.Verification
dart analyze: 0 issues found.dart test: All 185 tests passed acrossline_scanner,span_scanner,string_scanner, anderror_test.dart format: Code formatted according to Dart style guide.Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.