Allow double click on tab headers to also reset checkboxes#21550
Open
piratenpanda wants to merge 1 commit into
Open
Allow double click on tab headers to also reset checkboxes#21550piratenpanda wants to merge 1 commit into
piratenpanda wants to merge 1 commit into
Conversation
piratenpanda
changed the title
piratenpanda
marked this pull request as draft
July 15, 2026 05:15
piratenpanda
marked this pull request as ready for review
July 15, 2026 05:32
Collaborator
|
Sounds like a useful feature (to me) but should be carefully weighed against the confusion it might cause in people who are a bit clumsy clicking and might double click the header by accident. |
Contributor
Author
|
double clicking already exists. This PR only extends this feature to checkboxes on those tabs. Not resetting these but all the sliders is more confusing to me tbh |
piratenpanda
marked this pull request as draft
July 15, 2026 19:49
piratenpanda
force-pushed
the
checkbox-reset
branch
from
July 15, 2026 19:59
ad49b4f to
22a5f76
Compare
Contributor
Author
|
still breaks filmic for example. will look into this |
piratenpanda
force-pushed
the
checkbox-reset
branch
from
July 15, 2026 20:10
22a5f76 to
e5f1246
Compare
piratenpanda
marked this pull request as ready for review
July 15, 2026 20:10
TurboGit
added
priority: low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the spektrafilm module layout I found that double clicking on tab headers does not reset checkboxes in the respective tab. This PR adds this feature. I didn't find a discussion about this topic so feel free to close this PR if another consensus was reached some time ago.
Co-authored with Claude.