gtk4-prep: version-guard GdkVisual APIs for GTK4#21543
Open
Arecsu wants to merge 1 commit into
Open
Conversation
In GTK4, all visuals are RGBA and GdkVisual does not exist. Guard the Wayland-specific GdkVisual setup (gdk_screen_get_rgba_visual, gtk_widget_set_visual, GdkVisual type, gtk_widget_set_app_paintable, GdkScreen) with #if !GTK_CHECK_VERSION(4, 0, 0). Move the pop->offcut / height updates outside the guard since they are not GTK API calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: "Stop using non-RGBA visuals" #15920 #20433
There is no other place across darktable's current source code other than this one at
bauhaus.cwhen it comes to non-RGBA visuals, AFAIK. According to https://docs.gtk.org/gtk4/migrating-3to4.html:In preparation for GTK4, guard the Wayland-specific GdkVisual setup (gdk_screen_get_rgba_visual, gtk_widget_set_visual, GdkVisual type, gtk_widget_set_app_paintable, GdkScreen) with
#if !GTK_CHECK_VERSION(4, 0, 0).Move the
pop->offcut/heightupdates outside the guard since they are not GTK API calls.Something should be done here when the actual transition to GTK4 happens. Hopefully this serves as a reminder!