Skip to content

Update analyze npq#1974

Open
joshqsumner wants to merge 20 commits into
v5.0from
update-analyze-npq
Open

Update analyze npq#1974
joshqsumner wants to merge 20 commits into
v5.0from
update-analyze-npq

Conversation

@joshqsumner

Copy link
Copy Markdown
Contributor

Describe your changes
Updated analyze.npq for new class structure and changed PSII_Data class to have ojip_light and ojip_dark attributes available if psl/psd/npq data was used.

Type of update
This is a feature update.

Associated issues
Part of #1926

Additional context
Follows after #1973 , this time strictly.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Jul 17, 2026
@joshqsumner joshqsumner added the update Updates an existing feature/method label Jul 17, 2026
@deepsource-io

deepsource-io Bot commented Jul 17, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0a9cf06...1029bec on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jul 17, 2026 8:59p.m. Review ↗
Code coverage Jul 17, 2026 8:59p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant