Update analyze.yii fornew psii#1971
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Jul 22, 2026 4:50p.m. | Review ↗ | |
| Code coverage | Jul 22, 2026 4:50p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
100% |
| Python | 100% [✓ above threshold] |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Pull request overview
Updates plantcv.analyze.yii to accept a PSII_data object (instead of a single PSII DataArray) and to support analyzing psd and/or psl frames from the refactored photosynthesis subpackage (Issue #1926).
Changes:
- Refactors
plantcv.analyze.yiisignature fromps_da→psand returns lists of results when multiple frames are present. - Updates unit tests to construct/use the new
ps-style input objects. - Updates user-facing documentation to reflect the API change.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| plantcv/plantcv/analyze/yii.py | Switches yii to consume PSII_data and iterate over psl/psd frames, returning lists. |
| tests/plantcv/analyze/test_yii.py | Updates tests to call analyze.yii(ps=...) using new synthetic inputs. |
| tests/conftest.py | Adds new synthetic PSII test data helpers to emulate PSII_data-style inputs. |
| docs/updating.md | Documents the breaking parameter rename and new return type (lists). |
| docs/analyze_yii.md | Updates function signature/return description for the new API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…anforthcenter/plantcv into update-analyze.yii-fornew-psii
Describe your changes
Updates
analyze.yiito use the changes toPSII_dataclass per #1926Type of update
This is a feature update
Associated issues
See roadmap in #1926
Additional context
I have this looping over the relevant frames and making a list of results from that loop, if we don't want to return lists of arrays and lists of histograms then we could add an argument to pick a frame from
psdandpsl.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md