Skip to content

Update analyze.yii fornew psii#1971

Open
joshqsumner wants to merge 12 commits into
v5.0from
update-analyze.yii-fornew-psii
Open

Update analyze.yii fornew psii#1971
joshqsumner wants to merge 12 commits into
v5.0from
update-analyze.yii-fornew-psii

Conversation

@joshqsumner

Copy link
Copy Markdown
Contributor

Describe your changes
Updates analyze.yii to use the changes to PSII_data class per #1926

Type of update
This is a feature update

Associated issues
See roadmap in #1926

Additional context
I have this looping over the relevant frames and making a list of results from that loop, if we don't want to return lists of arrays and lists of histograms then we could add an argument to pick a frame from psd and psl.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Jul 15, 2026
@joshqsumner joshqsumner added the update Updates an existing feature/method label Jul 15, 2026
@deepsource-io

deepsource-io Bot commented Jul 15, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0a9cf06...f303ec4 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jul 22, 2026 4:50p.m. Review ↗
Code coverage Jul 22, 2026 4:50p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner joshqsumner added the work in progress Mark work in progress label Jul 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates plantcv.analyze.yii to accept a PSII_data object (instead of a single PSII DataArray) and to support analyzing psd and/or psl frames from the refactored photosynthesis subpackage (Issue #1926).

Changes:

  • Refactors plantcv.analyze.yii signature from ps_daps and returns lists of results when multiple frames are present.
  • Updates unit tests to construct/use the new ps-style input objects.
  • Updates user-facing documentation to reflect the API change.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
plantcv/plantcv/analyze/yii.py Switches yii to consume PSII_data and iterate over psl/psd frames, returning lists.
tests/plantcv/analyze/test_yii.py Updates tests to call analyze.yii(ps=...) using new synthetic inputs.
tests/conftest.py Adds new synthetic PSII test data helpers to emulate PSII_data-style inputs.
docs/updating.md Documents the breaking parameter rename and new return type (lists).
docs/analyze_yii.md Updates function signature/return description for the new API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plantcv/plantcv/analyze/yii.py Outdated
Comment thread plantcv/plantcv/analyze/yii.py
Comment thread plantcv/plantcv/analyze/yii.py
Comment thread tests/conftest.py
Comment thread tests/conftest.py
Comment thread docs/updating.md Outdated
Comment thread tests/plantcv/analyze/test_yii.py
Comment thread docs/analyze_yii.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants