Skip to content

Ports change to json2csv from v4 to v5#1969

Merged
nfahlgren merged 4 commits into
v5.0from
port-json2csv-updates
Jul 13, 2026
Merged

Ports change to json2csv from v4 to v5#1969
nfahlgren merged 4 commits into
v5.0from
port-json2csv-updates

Conversation

@nfahlgren

@nfahlgren nfahlgren commented Jul 10, 2026

Copy link
Copy Markdown
Member

Describe your changes
In the v5 development branch, json2csv moved from the deprecated utils subpackage to the plantcv core package. This PR ports changes introduce in #1967 to the v5 branch.

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone Jul 10, 2026
@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Jul 10, 2026
@deepsource-io

deepsource-io Bot commented Jul 10, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6d55522...0ff4ba6 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jul 13, 2026 4:06p.m. Review ↗
Code coverage Jul 13, 2026 4:06p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner
joshqsumner self-requested a review July 13, 2026 14:37
@joshqsumner

Copy link
Copy Markdown
Contributor

Happy to have the change ported but it is a little redundant with some of the changes I made in parallel (I think this was me but I haven't blamed it)

line 95 of plantcv.parallel.run_parallel is

json2csv(config.results, os.path.splitext(config.results)[0])

So the extension is never used when running parallel anymore anyway. It's better for the specific tool to do this I think since you might call json2csv manually but if you want I can remove the call to os.path.splitext from run_parallel for a little less redundancy. @nfahlgren , would you like me to edit run_parallel as part of this?

@joshqsumner joshqsumner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nfahlgren
nfahlgren merged commit 0a9cf06 into v5.0 Jul 13, 2026
5 checks passed
@nfahlgren
nfahlgren deleted the port-json2csv-updates branch July 13, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality updates ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants