Adding a new by_text element selector helper in tests - #1406
Draft
pgiraud wants to merge 1 commit into
Draft
Conversation
pirlgon
approved these changes
Jun 20, 2024
MarionGiusti
approved these changes
Jun 20, 2024
bersace
reviewed
Jun 20, 2024
bersace
marked this pull request as draft
June 24, 2024 12:35
pgiraud
force-pushed
the
find_by_text
branch
2 times, most recently
from
July 21, 2026 06:37
7eb31ae to
0f0dd3f
Compare
This is helpful to select an element with the text it contains. The element tag can also be provided, to be more explicit.
Member
Author
|
I rebased my branch. However, I don't think it is worth merging it. While the new helper could be useful in the case where the element we want to select doesn't have an ID, according to selelium's documentation, using XPATH is not recommended. Unless we decide that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.