Skip to content

chore(parser): set "Async Capable" property when parsing text #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgiraud wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(parser): set "Async Capable" property when parsing text #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export enum Property {
ACTUAL_STARTUP_TIME = "Actual Startup Time",
ACTUAL_TOTAL_TIME = "Actual Total Time",
ALIAS = "Alias",
ASYNC_CAPABLE = "Async Capable",
AVERAGE_IO_READ_SPEED = "*I/O Read Speed",
AVERAGE_IO_WRITE_SPEED = "*I/O Write Speed",
AVERAGE_LOCAL_IO_READ_SPEED = "*Local I/O Read Speed",
Expand Down
10 changes: 10 additions & 0 deletions src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export class Node {
[Property.ACTUAL_ROWS_REVISED]!: number;
[Property.ACTUAL_STARTUP_TIME]?: number;
[Property.ACTUAL_TOTAL_TIME]?: number;
[Property.ASYNC_CAPABLE]: boolean = false;
[Property.EXCLUSIVE_COST]!: number;
[Property.EXCLUSIVE_DURATION]!: number;
[Property.EXCLUSIVE_LOCAL_DIRTIED_BLOCKS]!: number;
Expand Down Expand Up @@ -266,6 +267,15 @@ export class Node {
this[Property.PARALLEL_AWARE] = true
}

enum AsyncMatch {
NodeType = 2,
}
const asyncRegex = /^(Async\s+)(.*)/.exec(<string>this[Property.NODE_TYPE])
if (asyncRegex) {
this[Property.NODE_TYPE] = asyncRegex[AsyncMatch.NodeType]
this[Property.ASYNC_CAPABLE] = true
}

enum JoinMatch {
NodeType = 1,
}
Expand Down
1 change: 1 addition & 0 deletions src/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export default function useNode(node: Node, viewOptions: ViewOptions) {

const nodeName = computed((): string => {
let nodeName = isParallelAware.value ? "Parallel " : ""
nodeName += node[Property.ASYNC_CAPABLE] ? "Async " : ""
nodeName += node[Property.PARTIAL_MODE]
? node[Property.PARTIAL_MODE] + " "
: ""
Expand Down
1 change: 1 addition & 0 deletions src/services/__tests__/from-text/01-expect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"Plan": {
"Node Type": "Seq Scan",
"Async Capable": false,
"Parallel Aware": false,
"Relation Name": "tenk1",
"Startup Cost": 0,
Expand Down
54 changes: 36 additions & 18 deletions src/services/__tests__/from-text/35-expect
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"Actual Loops": 1,
"Plans": [
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frara",
"Alias": "population_1",
"Actual Startup Time": 0.724,
Expand All @@ -23,7 +24,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frbfc",
"Alias": "population_2",
"Actual Startup Time": 0.799,
Expand All @@ -32,7 +34,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frbre",
"Alias": "population_3",
"Actual Startup Time": 0.701,
Expand All @@ -41,7 +44,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frcor",
"Alias": "population_4",
"Actual Startup Time": 0.622,
Expand All @@ -50,7 +54,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frcvl",
"Alias": "population_5",
"Actual Startup Time": 0.61,
Expand All @@ -59,7 +64,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frges",
"Alias": "population_6",
"Actual Startup Time": 0.74,
Expand All @@ -68,7 +74,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frgua",
"Alias": "population_7",
"Actual Startup Time": 0.653,
Expand All @@ -77,7 +84,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frguf",
"Alias": "population_8",
"Actual Startup Time": 13.221,
Expand All @@ -86,7 +94,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frhdf",
"Alias": "population_9",
"Actual Startup Time": 3.847,
Expand All @@ -95,7 +104,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_fridf",
"Alias": "population_10",
"Actual Startup Time": 0.667,
Expand All @@ -104,7 +114,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frlre",
"Alias": "population_11",
"Actual Startup Time": 0.65,
Expand All @@ -113,7 +124,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frmay",
"Alias": "population_12",
"Actual Startup Time": 1.321,
Expand All @@ -122,7 +134,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frmtq",
"Alias": "population_13",
"Actual Startup Time": 0.911,
Expand All @@ -131,7 +144,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frnaq",
"Alias": "population_14",
"Actual Startup Time": 0.695,
Expand All @@ -140,7 +154,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frnor",
"Alias": "population_15",
"Actual Startup Time": 0.761,
Expand All @@ -149,7 +164,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frocc",
"Alias": "population_16",
"Actual Startup Time": 9.212,
Expand All @@ -158,7 +174,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frpac",
"Alias": "population_17",
"Actual Startup Time": 0.44,
Expand All @@ -167,7 +184,8 @@
"Actual Loops": 1
},
{
"Node Type": "Async Foreign Scan",
"Node Type": "Foreign Scan",
"Async Capable": true,
"Relation Name": "population_frpdl",
"Alias": "population_18",
"Actual Startup Time": 1.074,
Expand Down
1 change: 1 addition & 0 deletions src/services/help-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ const notMiscProperties: string[] = [
Property.ACTUAL_ROWS_FRACTIONAL,
Property.DISABLED,
Property.WORKER_NUMBER,
Property.ASYNC_CAPABLE,
]

export function shouldShowProp(key: string, value: unknown): boolean {
Expand Down
Loading