Skip to content

curve,ed: Update digest and sha2 deps - #875

Merged
tarcieri merged 3 commits into
mainfrom
bump-digest
Feb 2, 2026
Merged

curve,ed: Update digest and sha2 deps#875
tarcieri merged 3 commits into
mainfrom
bump-digest

Conversation

@rozbb

@rozbb rozbb commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

The build is currently broken

error[E0432]: unresolved import `digest::crypto_common`
   --> curve25519-dalek/src/edwards.rs:109:65
    |
109 |     FixedOutput, HashMarker, array::typenum::U64, consts::True, crypto_common::BlockSizeUser,
    |                                                                 ^^^^^^^^^^^^^ could not find `crypto_common` in `digest`

This is because there was a breaking change between digest 0.11.0-rc.8 and 0.11.0-rc.11.

@rozbb
rozbb requested a review from tarcieri February 2, 2026 19:20
@tarcieri

tarcieri commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Would be good to bump sha2 to v0.11.0-rc.5 too... and do the same for ed25519-dalek

@rozbb rozbb changed the title Update digest dep curve,ed: Update digest and sha2 deps Feb 2, 2026
@rozbb

rozbb commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

Done. I also just checked in a freshly updated Cargo.lock

@tarcieri

tarcieri commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Awesome! Too bad Actions seems to be horribly broken right now

@tarcieri
tarcieri merged commit 59305b4 into main Feb 2, 2026
75 of 130 checks passed
@tarcieri
tarcieri deleted the bump-digest branch February 2, 2026 23:39
@nabetti1720

Copy link
Copy Markdown

We would like to thank everyone involved for their dedicated efforts. :)
By the way, are you planning to release a new version soon?

RustCrypto/rustls-rustcrypto#112
It's probably blocked by this issue, so as soon as a new version is released we can move forward.

@tarcieri

tarcieri commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

@nabetti1720 it's blocked on new releases of the @RustCrypto crates like digest, sha2, and signature, and this: zkcrypto/ff#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants