Bump edition to 2024 and crate versions to prereleases - #775
Conversation
|
Perhaps I'll just get rid of the derive and write the impl manually. Edit: aah, it's because of |
8adc4f7 to
2745a29
Compare
This represents the first breaking change in a new release series, bumping all crates to the 2024 edition of Rust. As such, the version numbers of all crates have been incremented to represent a new prerelease series: - `curve25519-dalek`: v5.0.0-pre - `ed25519-dalek`: v3.0.0-pre - `x25519-dalek`: v3.0.0-pre Note that this commit isn't intended to cut associated crate releases of these on crates.io, but is merely bumping the version numbers to denote there are pending breaking changes. This commit also includes rustfmt changes which were made as part of the 2024 edition. Also includes clippy fixes.
2745a29 to
29794e8
Compare
rozbb
left a comment
rozbb
left a comment
There was a problem hiding this comment.
One Q: is the x25519 version bump just bc of the edition bump? Otherwise there’s nothing breaking right
|
Technically the edition bump itself is not breaking per our SemVer policy, however subsequent changes we plan on making (e.g. #762) will be. If you'd prefer I can extract the version bumps out into a separate PR. |
|
I think it's fine, ty |
2 participants
This represents the first breaking change in a new release series, bumping all crates to the 2024 edition of Rust.
As such, the version numbers of all crates have been incremented to represent a new prerelease series:
curve25519-dalek: v5.0.0-preed25519-dalek: v3.0.0-prex25519-dalek: v3.0.0-preNote that this commit isn't intended to cut associated crate releases of these on crates.io, but is merely bumping the version numbers to denote there are pending breaking changes.
This commit also includes rustfmt changes which were made as part of the
2024 edition.