poolmanager: update wrandom partition to respect gap - #7868
Merged
Merged
Conversation
kofemann
marked this pull request as draft
August 21, 2025 17:03
Motivation: The wrandom partition ignores pool gap, thus can select a full pull. Issue: #7863 Modification: Update WRandomPartition to skip pools that will run into gap if accept the file. Added unit test to ensure the behavior. Result: full pulls are skipped by wrandom partition. Acked-by: Dmitry Litvintsev Target: master, 11.0, 10.2, 10.1, 10.0, 9.2 Require-book: no Require-notes: yes (cherry picked from commit a778f97) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
kofemann
force-pushed
the
issue-7863-wrandom-10.0
branch
from
August 21, 2025 17:21
04b559b to
58b9adb
Compare
kofemann
changed the title
kofemann
marked this pull request as ready for review
August 22, 2025 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The wrandom partition ignores pool gap, thus can select a full pull. Issue: #7863
Modification:
Update WRandomPartition to skip pools that will run into gap if accept the file. Added unit test to ensure the behavior.
Result:
full pulls are skipped by wrandom partition.
Acked-by: Dmitry Litvintsev
Target: master, 11.0, 10.2, 10.1, 10.0, 9.2
Require-book: no
Require-notes: yes
(cherry picked from commit a778f97)