fix: canceling account edits still saves updated profile picture - #201
fix: canceling account edits still saves updated profile picture#201jenniyan wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
xgraceyan
left a comment
There was a problem hiding this comment.
Did you get a chance to test it locally, now that the S3 bucket is working? I just tested it and it works for the "Accounts" page but not when I edit my own profile in /profile. Can we implement this fix in the Profile page as well?
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
|
Is this ready for re-review? Lmk, just re-request a review from me whenever it's ready |
Description
Profile picture is only officially updated after pressing save. Previously, it would be saved even if the user pressed Cancel on the account form.
Issues
Closes #185
Summary by cubic
Fixes the bug where canceling account or profile edits still saved a new profile picture. Previously, uploads committed immediately; now picture changes commit only on Save, and Cancel/exit keeps the original. Closes #185.
picturein audit snapshots when changed.en,es,fr, andzh.Written for commit c174614. Summary will update on new commits.