Update rustc to latest nightly - #1534
Conversation
|
I'll let you handle the changelog and version upgrade. |
W95Psp
left a comment
W95Psp
left a comment
There was a problem hiding this comment.
Thanks, looks great!
I was not aware of this Sized thing, it's quite interesting.
Before merging I think I need to add a quick phases that throw those constraints away.
I hope I can take some time today to do that, but it's not clear.
|
This should be fine now. |
|
Uh, we get a |
|
Huh weird, you don't use the MIR though do you? Didn't get any issues on the charon side. |
|
No, that's even weirder: it has nothing to do with the frontend! |
|
I'll try to minimize |
|
oh wow, what cursed thing have you done x) |
|
Ah, someone got the same bug and minimized: rust-lang/rust#143534. When that PR is merged into rust, we can update the pin of rustc and finally merge that PR. |
|
rust-lang/rust#143551 has been merged, I've moved the nightly pin forward! |
|
Thank you so much, let's merge! |
|
The bug was not entirely fixed, see rust-lang/rust#143700. |
|
@Nadrieril is actually taking care of the update! Thanks @Nadrieril 😃 |
Charon uses its own fork of hax for the time being.
We are probably not going to use most of attribute kinds. After chatting with @Nadrieril, for easing rustc updates, I'm dropping most of the attributes kinds, hinding them behind a `Todo` variant.
|
Waiting for #1558 |
2 participants
This updates rustc to the latest nightly. Required to get recent changes in a helper function that we need in charon to compute discriminant layouts.
You'll notice that traits now get a default
Self: MetaSizedbound. This is the consequence of the in-progress reqork of theSizedtrait to add more granularity; see rust-lang/rust#137944.