fix(ci): clean /homeless-shelter before Renovate's Nix commands - #279
Conversation
Nix runs the post-build hook only after a build succeeds, so a failed build leaves /homeless-shelter behind and every Nix command after it fails the purity check instead of doing its work. This commit has the crossplane-nix launcher clean the directory on the way in as well. We keep the post-build hook because it cleans up between builds within a single Nix invocation, which the launcher that only runs once before the Nix invocation can't do. Signed-off-by: Jared Watts <jbw976@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Renovate entrypoint documentation now distinguishes post-build cleanup from failure cleanup. The ChangesRenovate Nix cleanup
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized CI change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description of your changes
This PR ports crossplane/crossplane-runtime#1118 from crossplane-runtime to this
crossplane/clirepo as well:I have:
./nix.sh flake checkto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.