Skip to content

fix(ci): clean /homeless-shelter before Renovate's Nix commands - #279

Merged
haarchri merged 1 commit into
crossplane:mainfrom
jbw976:renovate-cleanup-failures
Aug 14, 2026
Merged

fix(ci): clean /homeless-shelter before Renovate's Nix commands#279
haarchri merged 1 commit into
crossplane:mainfrom
jbw976:renovate-cleanup-failures

Conversation

@jbw976

@jbw976 jbw976 commented Aug 14, 2026

Copy link
Copy Markdown
Member

Description of your changes

This PR ports crossplane/crossplane-runtime#1118 from crossplane-runtime to this crossplane/cli repo as well:

I have:

Need help with this checklist? See the cheat sheet.

Nix runs the post-build hook only after a build succeeds, so a failed
build leaves /homeless-shelter behind and every Nix command after it
fails the purity check instead of doing its work.

This commit has the crossplane-nix launcher clean the directory on the
way in as well. We keep the post-build hook because it cleans up between
builds within a single Nix invocation, which the launcher that only runs
once before the Nix invocation can't do.

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
jbw976 requested review from a team, jcogilvie and tampakrap as code owners August 14, 2026 20:22
@jbw976
jbw976 requested review from adamwg and removed request for a team August 14, 2026 20:22
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 09a76d48-18a3-4ab8-8083-3aa191ba7a01

📥 Commits

Reviewing files that changed from the base of the PR and between 3c8f298 and e994fac.

📒 Files selected for processing (1)
  • .github/renovate-entrypoint.sh

📝 Walkthrough

Walkthrough

The Renovate entrypoint documentation now distinguishes post-build cleanup from failure cleanup. The crossplane-nix launcher removes /homeless-shelter contents before starting Nix.

Changes

Renovate Nix cleanup

Layer / File(s) Summary
Pre-launcher cleanup
.github/renovate-entrypoint.sh
The crossplane-nix launcher cleans /homeless-shelter before forwarding arguments to Nix. Comments describe the separate cleanup points for successful and failed builds.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to e994f

This localized CI change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

  • crossplane/cli#257: Adds the related /homeless-shelter cleanup logic in the Renovate entrypoint.

Suggested reviewers: jcogilvie

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title is 63 characters and clearly describes cleaning /homeless-shelter before Renovate's Nix commands.
Description check ✅ Passed The description explains that the change ports a related PR and updates CI cleanup behavior for Renovate's Nix commands.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Breaking Changes ✅ Passed The pull-request diff changes only .github/renovate-entrypoint.sh; it does not modify files under apis/** or cmd/**, so the check's failure conditions do not apply.
Feature Gate Requirement ✅ Passed The diff changes only .github/renovate-entrypoint.sh to clean /homeless-shelter before Nix commands; it adds no experimental API or product feature requiring a feature flag.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@haarchri
haarchri merged commit a14c50d into crossplane:main Aug 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants