fix(dependency): generate schemas for transitive package dependencies - #270
fix(dependency): generate schemas for transitive package dependencies#270haarchri wants to merge 1 commit into
Conversation
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
|
Warning Review limit reached
Next review available in: 13 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description of your changes
When generating schemas for xpkg dependencies, the CLI only processed the directly declared package and never read the fetched package's own
spec.dependsOnmetadata. As a result, transitive dependencies were skipped, for example, addingprovider-aws-s3did not generate schemas forprovider-family-aws, which holds the ProviderConfig CRDs.This change makes
addPackagerecursively process the dependencies declared in a package's metadata after generating its schemas:schemas.Addsucceeds, the newaddTransitiveDepsiteratespkg.GetDependencies()and recursively adds each entry. This covers all xpkg schema paths:dependency add,project build/run,dependency update-cache, and directAddPackagecalls.Manager(keyed by unresolved ref, claimed before fetching) deduplicates shared transitive dependencies across the concurrentAddAllgoroutines — a family provider shared by several providers is fetched exactly once — and breaks dependency cycles.crossplane-project.yaml. Therefreshflag propagates soupdate-cachere-pulls transitive packages too. Transitive failures fail hard with an error naming both the transitive ref and its parent, matching the validate flow.xpkgRefhelper and addeddependencyRepoto read the image from new-stylepackage:and deprecatedprovider:/configuration:/function:dependency fields.How has this code been tested
have an open draft PR modelplaneai/modelplane#397 remove the family providers and get all family provider schemas by default
Fixes #
I have:
./nix.sh flake checkto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.