docs(example/externalRef): mention how to match cluster-scoped resources - #115
Open
nkzk wants to merge 1 commit into
Open
docs(example/externalRef): mention how to match cluster-scoped resources#115nkzk wants to merge 1 commit into
nkzk wants to merge 1 commit into
Conversation
nkzk
marked this pull request as draft
August 13, 2026 08:11
Signed-off-by: Nikita Zakharov <nikita.zakharov@statnett.no>
nkzk
force-pushed
the
docs-externalref-cluster-scoped-resources
branch
from
August 13, 2026 08:13
4939bf3 to
c6fb102
Compare
nkzk
marked this pull request as ready for review
August 13, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
We are trying out function-kro, and really liked the examples in this repo to get started! :)
We stumbled into an issue with referencing cluster-scoped resources in
externalRef.The kro-documentation mentions that you can reference cluster-scoped resources by just omitting namespace, but it doesnt specify that this only works for the external collection reference (label selector).
This fact is a bit hidden in the code:
Maybe this could be useful to contribute to the upstream docs as well, but thought it's nice to start with a small note here.
What do you think?
I have:
- [ ] Added or updated unit tests for my change.