Skip to content

Create columns to track settlement gas info #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmg-duarte merged 3 commits into from
Aug 3, 2026
+23 −8
Merged

Create columns to track settlement gas info #4697

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4f41a1
Create columns to track settlement gas info
jmg-duarte Aug 3, 2026
b10e29b
Update database/sql/V116__settlement_gas_cost.sql
jmg-duarte Aug 3, 2026
eb5c504
update readme
jmg-duarte Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions database/sql/V116__settlement_gas_cost.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
-- Store the actual on-chain gas cost of each settlement transaction.
--
-- These values are read from the transaction receipt by the autopilot's
-- settlement observer), letting the orderbook attribute a real gas cost
Comment thread
jmg-duarte marked this conversation as resolved.
Outdated
-- to individual trades and orders.
--
-- Nullable: only populated for settlements observed after this migration is
-- deployed (no historical backfill).
ALTER TABLE settlements
ADD COLUMN gas_used numeric(78, 0),
ADD COLUMN effective_gas_price numeric(78, 0);
Comment on lines +9 to +11

@claude claude Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot reminder asks to update the DB README when adding columns. The settlements table docs still don't list gas_used / effective_gas_price — worth adding the two rows so the schema doc stays in sync.

Type/naming look good: numeric(78,0) matches the u256 convention used elsewhere (and the existing gas_used numeric(78,0) in V048__create_settlement_rewards.sql), and nullable additive columns are backward-compatible with the k8s rollout overlap.

Loading