Drop CoW AMM table - #4681
Open
fleupold wants to merge 4 commits into
Open
Conversation
|
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
Caused by: |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
MartinquaXD
marked this pull request as ready for review
August 6, 2026 09:15
MartinquaXD
approved these changes
Aug 6, 2026
Contributor
|
Claude finished @MartinquaXD's task in 50s —— View job PR Review: Drop CoW AMM table
Result: LGTM ✅ — no issues found, nothing to flag inline. I verified the concerns relevant to a destructive DB migration:
One inherent note (no change needed): |
squadgazzz
approved these changes
Aug 6, 2026
fleupold
enabled auto-merge
August 6, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Followup to #4626, which MUST NOT go into the same release
Description
Due to timing concerns on startup cf #4624 (comment), deletion of the cow_amm table is deferred to another release.
Changes