Skip to content

Remove use of explicit * channel on documents - #652

Open
torcolvin wants to merge 1 commit into
mainfrom
fix-explicit-star-channel
Open

torcolvin wants to merge 1 commit into
mainfrom
fix-explicit-star-channel

Conversation

@torcolvin

Copy link
Copy Markdown
Collaborator
  • This is an anti-pattern for Sync Gateway. Using * channel is discouraged. If you want the user to have access to all documents, you could create a user with admin_channels of *
  • Note that using a * channel results in a different query code pathway by Sync Gateway than if specific channels are used. I think it is more valuable to test explicit channels because it can also catch channel assignment issues.
  • Add claude instructions to prevent this code from coming back.

🤖 Generated with Claude Code

- This is an anti-pattern for Sync Gateway. Using * channel is discouraged. If you want the user to have access to all documents, you could create a user with admin_channels of *
- Note that using a * channel results in a different query code pathway by Sync Gateway than if specific channels are used. I think it is more valuable to test explicit channels because it can also catch channel assignment issues.
- Add claude instructions to prevent this code from coming back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants