Skip to content

chore(openjpeg): update OpenJPEG submodule to upstream v2.5.4#78

Open
sedghi wants to merge 1 commit into
mainfrom
chore/openjpeg-submodule-2.5.4
Open

chore(openjpeg): update OpenJPEG submodule to upstream v2.5.4#78
sedghi wants to merge 1 commit into
mainfrom
chore/openjpeg-submodule-2.5.4

Conversation

@sedghi

@sedghi sedghi commented Jul 9, 2026

Copy link
Copy Markdown
Member

Third codec submodule upgrade (after openjph #76, charls #77).

Bumps packages/openjpeg/extern/openjpeg from 2d606701 (~2.5.0-era, Oct 2022) to upstream OpenJPEG v2.5.4 (2025-09-20). Fork PR: cornerstonejs/openjpeg#3.

  • No custom patches — clean version advance (fork had zero divergence).
  • Same-minor-line jump (2.5.0 → 2.5.4), so API drift against our openjpeg glue should be small — but CI is the check.
  • No Debug-build issue (openjpeg builds optimized by default).

CI validates compile against our glue + byte-identical pixel goldens + dist-size. Not built locally; iterating on CI. Not for merge.

Advances from 2d606701 (~2.5.0-era, Oct 2022) to upstream v2.5.4 (2025-09-20).
No custom fork patches (clean version advance). Fork PR: cornerstonejs/openjpeg.
CI is the first build/validation of v2.5.4 against our glue.
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sedghi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c93e7297-b342-4e46-8f32-4d85d2c78e5b

📥 Commits

Reviewing files that changed from the base of the PR and between 9c086c9 and 3518c7d.

📒 Files selected for processing (1)
  • packages/openjpeg/extern/openjpeg
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/openjpeg-submodule-2.5.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jul 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 7.97%

⚡ 1 improved benchmark
✅ 19 untouched benchmarks
⏩ 99 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime instantiate+destroy J2KDecoder x50 151.2 µs 140 µs +7.97%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/openjpeg-submodule-2.5.4 (3518c7d) with main (a88a461)2

Open in CodSpeed

Footnotes

  1. 99 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9c086c9) during the generation of this report, so a88a461 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sedghi

sedghi commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Status: green except dist-size (small, expected size growth)

openjpeg v2.5.4 (from ~2.5.0-era, Oct 2022). All real checks pass: build, test, browser-smoke, CodSpeed. No build fixes, no glue changes — clean same-minor-line advance, no custom patches. Decode output byte-identical (goldens pass).

The one red — dist-size — is a modest, genuine size increase from ~3 years of upstream 2.5.x patches:

  • openjpegjs.js +0.9% raw / +1.1% gzip
  • openjpegjs_decode.js +1.4% / +1.8%
  • openjpegwasm.wasm +0.9% / +1.3%

Not a bug — a re-baseline decision. This fits the "modest growth for currency/stability" bar.

Fork PR: cornerstonejs/openjpeg#3 — MERGEABLE.

Actions to merge

  1. Merge fork openjpeg#3.
  2. Re-baseline dist-size: gh run download <this-PR-run-id> --pattern 'dist-*' -D tmp/ && node tools/dist-size/check.js --update --artifacts tmp/ && commit (scoped to openjpeg's entries), then dist-size goes green.
  3. Merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant