docs: default to IDE Extensions section and add favicon#12636
Merged
Conversation
Change the no-match fallback in DocsShell findActiveTab to return the first nav tab (IDE Extensions) instead of the last (CLI), so the docs root defaults to IDE Extensions. Add app/favicon.ico so /favicon.ico requests resolve via App Router metadata instead of falling through the optional catch-all route. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findActiveTabindocs-site/components/docs/DocsShell.tsxpreviously returned the last nav tab (CLI) as the no-match fallback. The docs root (/) renders theindexpage whose slug isn't in any tab, so it hit this fallback and defaulted to CLI. Changed it to return the first tab (IDE Extensions). All sections remain present; CLI is still reachable.docs-site/app/favicon.icoso/favicon.icorequests resolve via App Router metadata instead of falling through the optional catch-all route (which spammed a Next "missing param / output: export" error).Test plan
npm run buildindocs-site/(Next static export,output: export) succeedsfavicon.icoemitted toout/and referenced from generated HTMLUsing a
docs:conventional-commit prefix so semantic-release does not cut a package release.Made with Cursor