Skip to content

Refactor the man page - #451

Merged
giuseppe merged 6 commits into
containers:mainfrom
bertronika:man-refactor
Jan 17, 2026
Merged

giuseppe merged 6 commits into
containers:mainfrom
bertronika:man-refactor

Conversation

@bertronika

Copy link
Copy Markdown
Contributor

This is a rehaul of fuse-overlayfs.1.md. I've mostly addressed the formatting problems but also tried to improve some of the explanations. Details are explained in commit messages. Tested with go-md2man 2.0.0. Before and after previews are attached below, albeit without any rich formatting.

Man page before
Man page after

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe

Copy link
Copy Markdown
Member

sorry for the delay in the review. Could you please rebase?

- use definition lists (:) to explain options
- remove line breaks that get carried over after being processed by
  go-md2man
- add and explain some missing options (-f, -d, -h, -V)
- split dynamic mapping into its own section, go-md2man can't handle
  multiple paragraphs in definition lists

Signed-off-by: Nejc Bertoncelj <bertronika@mailo.com>
Signed-off-by: Nejc Bertoncelj <bertronika@mailo.com>
Signed-off-by: Nejc Bertoncelj <bertronika@mailo.com>
I thought in some cases go-md2man carried new lines into output files.
Since it seems I was mistaken, restore wrapping at 79 characters.

Signed-off-by: Nejc Bertoncelj <bertronika@mailo.com>
Signed-off-by: Nejc Bertoncelj <bertronika@mailo.com>
Signed-off-by: Nejc Bertoncelj <bertronika@mailo.com>
@bertronika

Copy link
Copy Markdown
Contributor Author

Done. I've incorporated changes from @tjwoodall's commit and regenerated the file.

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
giuseppe merged commit 51108ae into containers:main Jan 17, 2026
8 checks passed
@bertronika
bertronika deleted the man-refactor branch January 17, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants