refactor: rename target-type parameters for naming consistency - #6
Merged
Merged
Conversation
Add-/Remove-SqlElasticJobTarget's -DatabaseName, -ElasticPoolName and -ShardMapName are renamed to -TargetDatabaseName, -TargetElasticPoolName and -TargetShardMapName, matching the existing -TargetServerName/-TargetGroupName naming and avoiding a name collision with unrelated DatabaseName properties elsewhere in the pipeline (e.g. the agent's own job database). The underlying Add-/Remove-AzSqlElasticJobTarget cmdlets keep their original DatabaseName/ElasticPoolName/ShardMapName parameter names, so these three are now mapped explicitly instead of relying on Add-OptionalParameter's same-name forwarding; RefreshCredentialName/Exclude still go through Add-OptionalParameter since their names are unchanged. No back-compat alias was added since the module is still unreleased/preview. Updates unit and integration tests and a CHANGELOG entry. Co-authored-by: AI Assistant <ai@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-/Remove-SqlElasticJobTarget's -DatabaseName, -ElasticPoolName and -ShardMapName are renamed to -TargetDatabaseName, -TargetElasticPoolName and -TargetShardMapName, matching the existing -TargetServerName/-TargetGroupName naming and avoiding a name collision with unrelated DatabaseName properties elsewhere in the pipeline (e.g. the agent's own job database).
The underlying Add-/Remove-AzSqlElasticJobTarget cmdlets keep their original DatabaseName/ElasticPoolName/ShardMapName parameter names, so these three are now mapped explicitly instead of relying on Add-OptionalParameter's same-name forwarding; RefreshCredentialName/Exclude still go through Add-OptionalParameter since their names are unchanged.
No back-compat alias was added since the module is still unreleased/preview. Updates unit and integration tests and a CHANGELOG entry.