Skip to content

fix(ci): migrate preview deploy to ECR, fix prod image mapping #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tieubao merged 2 commits into from
Jul 19, 2026
Merged

fix(ci): migrate preview deploy to ECR, fix prod image mapping #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2520be
fix(ci): migrate preview deploy off deleted GCP SA to ECR
tieubao Jul 19, 2026
18783cf
fix(ci): key prod kustomize image edit on the legacy GAR name
tieubao Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions .github/workflows/gke-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and Deploy to GKE Preview
name: Build and Deploy to Preview (ECR)

on:
push:
Expand All @@ -7,10 +7,16 @@ on:

# Environment variables available to all jobs and steps in this workflow
env:
# AWS ECR, mirroring gke-prod.yml's migration off the deleted GCP service
# account (see that file's header note). Same registry, preview overlay.
GITHUB_SHA: ${{ github.sha }}
REGISTRY_HOSTNAME: gcr.io
GKE_PROJECT: console-labs-prod
IMAGE: consolelabs/mochi-api
AWS_REGION: ap-southeast-1
ECR_REGISTRY: 768727713577.dkr.ecr.ap-southeast-1.amazonaws.com
IMAGE: mochi/api
# The kustomize overlays still key their images: transform on the legacy
# GAR name referenced by deployment.yaml, so `kustomize edit set image`
# must use it as the old name or the edit is a no-op.
LEGACY_IMAGE_NAME: asia-southeast1-docker.pkg.dev/console-labs-prod/consolelabs/mochi-api
K8S_ENVIRONMENT: preview

jobs:
Expand All @@ -21,24 +27,21 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- id: "auth"
name: "Authenticate to Google Cloud"
uses: "google-github-actions/auth@v0"
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
with:
credentials_json: "${{ secrets.GCP_CREDENTIALS }}"
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.AWS_REGION }}

- name: "Set up Cloud SDK"
uses: "google-github-actions/setup-gcloud@v0"

- name: Setup Docker
run: |
gcloud auth configure-docker gcr.io
- name: Login to Amazon ECR
uses: aws-actions/amazon-ecr-login@v2

# Build & Push the Docker image
- name: Build & Push
run: |
docker build -t $REGISTRY_HOSTNAME/$GKE_PROJECT/$IMAGE:${GITHUB_SHA} .
docker push $REGISTRY_HOSTNAME/$GKE_PROJECT/$IMAGE:${GITHUB_SHA}
docker build -t $ECR_REGISTRY/$IMAGE:${GITHUB_SHA} .
docker push $ECR_REGISTRY/$IMAGE:${GITHUB_SHA}
# Setup kustomize
- name: Setup kustomize
run: |
Expand All @@ -57,6 +60,6 @@ jobs:
cd ./infrastructure/mochi-api/$K8S_ENVIRONMENT
git config user.name jphuc96
git config user.email jphuc96@gmail.com
/tmp/kustomize edit set image $REGISTRY_HOSTNAME/$GKE_PROJECT/$IMAGE=$REGISTRY_HOSTNAME/$GKE_PROJECT/$IMAGE:${GITHUB_SHA}
/tmp/kustomize edit set image $LEGACY_IMAGE_NAME=$ECR_REGISTRY/$IMAGE:${GITHUB_SHA}
git commit -am "[skip ci] mochi-api ${K8S_ENVIRONMENT} image update"
git push origin main
6 changes: 5 additions & 1 deletion .github/workflows/gke-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ env:
AWS_REGION: ap-southeast-1
ECR_REGISTRY: 768727713577.dkr.ecr.ap-southeast-1.amazonaws.com
IMAGE: mochi/api
# The kustomize overlays still key their images: transform on the legacy
# GAR name referenced by deployment.yaml, so `kustomize edit set image`
# must use it as the old name or the edit is a no-op.
LEGACY_IMAGE_NAME: asia-southeast1-docker.pkg.dev/console-labs-prod/consolelabs/mochi-api
K8S_ENVIRONMENT: prod

jobs:
Expand Down Expand Up @@ -56,7 +60,7 @@ jobs:
cd ./infrastructure/mochi-api/$K8S_ENVIRONMENT
git config user.name jphuc96
git config user.email jphuc96@gmail.com
/tmp/kustomize edit set image $ECR_REGISTRY/$IMAGE=$ECR_REGISTRY/$IMAGE:${GITHUB_REF_NAME}
/tmp/kustomize edit set image $LEGACY_IMAGE_NAME=$ECR_REGISTRY/$IMAGE:${GITHUB_REF_NAME}
git commit -am "[skip ci] mochi-api ${K8S_ENVIRONMENT} image update"
git push origin main

Expand Down
Loading