Repository navigation
Make Soroban confirmation polling configurable - #246
Merged
Jaydbrown merged 1 commit intoJul 29, 2026
Merged
Conversation
Jaydbrown
force-pushed
the
agent/configurable-polling-217
branch
from
July 29, 2026 10:31
ada6bd3 to
e333201
Compare
Contributor
Author
|
Thanks for merging this and the related streamFi-sdk PRs (#238, #240, #242, #243, #245, #246). Could you confirm the payout process for these merged Stellar Wave items? Preferred payout options:
If Stellar-native payout is required, please let me know and I will provide a Stellar public key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConduitConfigwith current behavior preserved (1000ms,30attempts)ConfirmationPollingOptionsto low-levelinvokeContract()StreamsModule._sendAndPoll()honor the client-level polling configinvokeContract()polling optionsCloses #217.
Validation
npm test -- src/tests/streams-success.test.ts src/tests/soroban-rate-limit.test.ts-> 2 files / 17 tests passednpm run build-> passednpm run lint-> passedgit diff --check-> passednpm run typecheckis blocked by an existing WalletConnect edge-case test issue unrelated to this change:chainId: undefinedis not assignable withexactOptionalPropertyTypesnpm testis blocked by an existing pagination cursor expectation insrc/tests/pagination-cursor.test.ts; the focused polling suites passPayout
This is Stellar Wave / USDC-compatible. EVM/Base USDC address:
0x2f8081562ac67467d1cbd40ab3120849c1f587da.If payment must be Stellar-native USDC, please ask for a Stellar public key before sending.