Skip to content

CODAP-335 add georaster support#1921

Closed
scytacki wants to merge 3 commits into
mainfrom
CODAP-335-georaster
Closed

CODAP-335 add georaster support#1921
scytacki wants to merge 3 commits into
mainfrom
CODAP-335-georaster

Conversation

@scytacki

@scytacki scytacki commented Apr 22, 2025

Copy link
Copy Markdown
Member

This can be tested with the neo-codap-plugin:

https://codap3.concord.org/branch/georaster/?di=https://models-resources.concord.org/neo-codap-plugin/branch/codap-slider/index.html

This adds 600KB to packed javascript file. It goes from 6.6MB to 7.2MB, so close to a 10% increase.

@codecov

codecov Bot commented Apr 22, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 18.24818% with 112 lines in your changes missing coverage. Please review.

Project coverage is 70.31%. Comparing base (72c642c) to head (6da8ad8).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/map/utilities/georaster-utils.ts 12.71% 95 Missing and 8 partials ⚠️
v3/src/components/map/map-component-handler.ts 36.36% 7 Missing ⚠️
v3/src/components/map/models/map-content-model.ts 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (72c642c) and HEAD (6da8ad8). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (72c642c) HEAD (6da8ad8)
cypress 10 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1921       +/-   ##
===========================================
- Coverage   87.73%   70.31%   -17.43%     
===========================================
  Files         668      669        +1     
  Lines       34192    34327      +135     
  Branches     9118     9727      +609     
===========================================
- Hits        30000    24136     -5864     
- Misses       4186     9666     +5480     
- Partials        6      525      +519     
Flag Coverage Δ
cypress 42.19% <13.17%> (-30.09%) ⬇️
jest 56.11% <7.29%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress

cypress Bot commented Apr 22, 2025

Copy link
Copy Markdown

codap-v3    Run #7166

Run Properties:  status check passed Passed #7166  •  git commit 6da8ad8fba: Merge branch 'main' into CODAP-335-georaster
Project codap-v3
Branch Review CODAP-335-georaster
Run status status check passed Passed #7166
Run duration 01m 47s
Commit git commit 6da8ad8fba: Merge branch 'main' into CODAP-335-georaster
Committer Scott Cytacki
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

this also adds some documentation about georasters
@scytacki scytacki added the v3 CODAP v3 label Apr 24, 2025
@scytacki

scytacki commented May 7, 2025

Copy link
Copy Markdown
Member Author

This PR is replaced with this one: #1928

@scytacki scytacki closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 CODAP v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant