CODAP-335 add georaster support#1921
Closed
scytacki wants to merge 3 commits into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
===========================================
- Coverage 87.73% 70.31% -17.43%
===========================================
Files 668 669 +1
Lines 34192 34327 +135
Branches 9118 9727 +609
===========================================
- Hits 30000 24136 -5864
- Misses 4186 9666 +5480
- Partials 6 525 +519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
CODAP-335-georaster
|
| Run status |
|
| Run duration | 01m 47s |
| Commit |
|
| Committer | Scott Cytacki |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
3
|
| View all changes introduced in this branch ↗︎ | |
this also adds some documentation about georasters
Member
Author
|
This PR is replaced with this one: #1928 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be tested with the neo-codap-plugin:
https://codap3.concord.org/branch/georaster/?di=https://models-resources.concord.org/neo-codap-plugin/branch/codap-slider/index.html
This adds 600KB to packed javascript file. It goes from 6.6MB to 7.2MB, so close to a 10% increase.