-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: add load-time inputs for include nodes #2467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Wirasm
merged 3 commits into
dev
from
archon/task-archon-fix-github-issue-experimental-1785918317060
Aug 5, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import type { DagNode } from './schemas'; | ||
| import { isCommandNode, isLoopNode } from './schemas'; | ||
|
|
||
| /** Return the command-file name used by a node, including deferred loop prompts. */ | ||
| export function getFileBackedCommandName(node: DagNode): string | undefined { | ||
| if (isCommandNode(node)) return node.command; | ||
| if (isLoopNode(node) && typeof node.loop.command === 'string') return node.loop.command; | ||
| return undefined; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to
base_branch: $BASE_BRANCH.Two reasons, and the second is the one that matters:
1.
mainis the wrong branch to name in this repo.mainis the release branch here; everything targetsdev. A reader who copies this example inherits the wrong default. (Unrelated but adjacent: a stale localrefs/remotes/origin/HEADon this machine was also pointing atmain, so the word showed up twice from two unrelated causes — that one's fixed separately.)2. It teaches hardcoding a branch name in the same paragraph that introduces the feature. Archon already provides
$BASE_BRANCHprecisely so authors don't do this. Using it here demonstrates something more interesting than a literal: a workflow variable flowing throughwith:into a block.Verified it works —
applyInputsMacrois a pure verbatimtext.replace, and this file has zero references tosubstituteWorkflowVariablesorBASE_BRANCH. So$BASE_BRANCHlands as literal text in the block's node body and resolves through normal runtime substitution, by exactly the mechanism the prose above already describes for$node.output. No code change needed — the doc line is the whole fix.Worth a sentence in the surrounding prose too: a
with:value can carry any variable the runtime substitutes, not just$node.output.