verifier: refactor az-snp-vtpm to avoid tss-esapi dep - #1
Open
shariqahmed-cohere wants to merge 1 commit into
Open
verifier: refactor az-snp-vtpm to avoid tss-esapi dep#1shariqahmed-cohere wants to merge 1 commit into
shariqahmed-cohere wants to merge 1 commit into
Conversation
shariqahmed-cohere
force-pushed
the
shariq/portable-azsnp
branch
from
September 10, 2026 15:18
151dc53 to
95e8364
Compare
az-snp-vtpm depends on tss-esapi to unmarshall TPM quotes which limits its portability to linux. This change replaces that dependency with tpm2-protocol (combined with az-cvm-vtpm) to allow verifier to compile on other platforms. Signed-off-by: Shariq Khalil Ahmed <shariq.ahmed@cohere.com> Co-authored-by: Cursor <cursoragent@cursor.com>
shariqahmed-cohere
force-pushed
the
shariq/portable-azsnp
branch
from
September 10, 2026 20:38
95e8364 to
9220bda
Compare
shariqahmed-cohere
marked this pull request as ready for review
September 11, 2026 19:23
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9220bda. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
az-snp-vtpm depends on tss-esapi to unmarshall TPM quotes which limits its portability to linux. This change replaces that dependency with tpm2-protocol (combined with az-cvm-vtpm) to allow verifier to compile on other platforms.
The new impl leverages existing non-azure SNP functionality along with tpm2-protocol and az-cvm-vtpm. It also adds validity window check on vcek to keep functionality 1-to-1 with the previous az-snp-vtpm flow.
Note
Medium Risk
Changes attestation verification for Azure SNP vTPM (TPM parsing and SNP/VCEK validation paths); behavior is intended to stay equivalent but any mismatch in TPM or certificate handling would affect trust decisions.
Overview
Refactors Azure SNP vTPM verification so the
az-snp-vtpm-verifierfeature no longer depends onaz-snp-vtpmortss-esapi(libtss2). TPM quote parsing now usestpm2-protocol; HCL handling comes fromaz-cvm-vtpmwith default features off so only the HCL path is linked unlesstpm-verifieropts intoaz-cvm-vtpm/verifier.SNP/VCEK checks are aligned with the existing
snp-verifier:sevcertificate chains, report signature verification, and sharedverify_report_tcb, plus an explicit VCEK not-before/not-after check that chain verification alone did not enforce. Legacy v0 evidence keeps a localQuotetype incompat.rsso JSON layout stays unchanged; Azure TDX vTPM keeps its ownFrom<Quote>forTpmQuoteso the SNP build path does not pull in libtss2.Reviewed by Cursor Bugbot for commit 9220bda. Bugbot is set up for automated code reviews on this repo. Configure here.