fix(ci): align workflow Node.js version with package engines - #3013
Open
MGPOCKY wants to merge 1 commit into
Open
fix(ci): align workflow Node.js version with package engines#3013MGPOCKY wants to merge 1 commit into
MGPOCKY wants to merge 1 commit into
Conversation
MGPOCKY
marked this pull request as ready for review
July 31, 2026 09:09
MGPOCKY
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
July 31, 2026 09:09
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to run CI/publish/release tasks on Node.js 18, aligning workflow runtime with the repository’s Node 18 toolchain expectations.
Changes:
- Bump
node-versionfrom 16 → 18 in the npm publish workflow. - Bump
node-versionfrom 16 → 18 in the release-draft workflow (two jobs). - Bump
node-versionfrom 16 → 18 in the bump-version-on-merge workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/publish-package-to-npm.yml | Updates publish job Node.js version pin to 18. |
| .github/workflows/create-a-release-draft.yml | Updates Node.js version pins to 18 in release-draft related jobs. |
| .github/workflows/bump-version-on-merge-next.yml | Updates Node.js version pin to 18 for automated version bumping. |
Suppressed comments (1)
.github/workflows/publish-package-to-npm.yml:25
- PR description claims
package.jsondeclaresengines.node/volta.nodeas18, but this repo’spackage.jsoncurrently has neitherenginesnorvoltafields (only.nvmrcpins Node tov18.20.1). Please either update the PR description or add the missing metadata if aligning CI toengines/voltais part of the intended change.
node-version: 18
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
22
to
26
| # Setup node environment | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 16 | ||
| node-version: 18 | ||
| registry-url: https://registry.npmjs.org/ |
Comment on lines
70
to
+73
| # Setup node environment | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 16 | ||
| node-version: 18 |
Comment on lines
64
to
+67
| # Setup node environment | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 16 | ||
| node-version: 18 |
Member
|
@MGPOCKY hey. Thanks for the PR, please, check comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Package metadata declares
engines.node/volta.node/.nvmrcas18, but CI workflows still pinnode-versionto a mismatched value.That can make CI run on a runtime the project no longer supports (or skip the version the package actually targets).
What changed
Update the affected workflow
node-versionpins so they satisfy18(using18where a concrete pin is needed)..github/workflows/bump-version-on-merge-next.ymlnode-version: 16→node-version: 18.github/workflows/create-a-release-draft.ymlnode-version: 16→node-version: 18node-version: 16→node-version: 18.github/workflows/publish-package-to-npm.ymlnode-version: 16→node-version: 18Test plan
engines.node/volta.node/.nvmrcis still18Found while auditing CI/package version consistency across popular repos.