Repository navigation
Remove legacy XcResult support for Xcode versions older than 16 - #505
Merged
Merged
Conversation
artemii-yanushevskyi
approved these changes
Oct 7, 2026
artemii-yanushevskyi
left a comment
Contributor
There was a problem hiding this comment.
Changes look solid.
Consider fail early with clear "Xcode 16+ required". Xcode < 16 no longer has a clear capability gate. Processing could fail with a generic parsing error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by #503 (comment).
Since PR #431 (released in 0.54.0) we have kept two XcResult to JUnit converters and picked one at runtime by the selected Xcode version. Xcode versions older than 16 no longer need support, so this PR removes the legacy converter.
Changes
LegacyXcResultConverter, thecodemagic.models.xctests.xcresult.legacy_xcresultmodule (ActionsInvocationRecordetc.) and its tests and mocks.XcResultToolmethodsis_legacy,get_bundleandget_object.Xcode16XcResultConverterintoXcResultConverter, which is no longer an abstract base class.Effect
xcode-projectactionsrun-tests,test-summaryandjunit-test-resultsneed Xcode 16+ to parse test results. With older Xcode versions they fail withParsing test results failed.Updated actions
xcode-project run-testsxcode-project test-summaryxcode-project junit-test-results