Build RecHitTools per event to fix cross-stream double-free

[felicepantaleo]

The five global associator producers mutated a shared RecHitTools member via setGeometry() inside const produce(), racing across streams and giving an ASAN double-free on the RecHitTools internal vector buffer.

fixes #51380

[cmsbuild]

cms-bot internal usage

[felicepantaleo]

type bugfix

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51529/50248

• There are other open Pull requests which might conflict with changes you have proposed:
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.cc modified in PR(s): Particle Flow cluster validation in ECAL #50292, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.h modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.cc modified in PR(s): Particle Flow cluster validation in ECAL #50292

[cmsbuild]

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

• SimCalorimetry/HGCalAssociatorProducers (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere, @sameasy this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b5000/54824/summary.html
COMMIT: 29159f3
CMSSW: CMSSW_20_1_X_2026-07-20-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51529/54824/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3548294
• DQMHistoTests: Total failures: 106
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3548170
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 163 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

+1