HGCal displaced gun validations

[fdoljanin]

HGCal displaced gun validations

PR description:

This PR improves HGCal Trackster validation by:

• adding displacement (R and alpha) and time metrics,
• fixing a segmentation fault when producing separate validation plots,
• making the association-score thresholds used for non-fake, merge, purity, and duplicate metrics configurable.

The output gains the new displacement and time plots. The default association thresholds preserve the previous metric definitions. This PR has no external dependencies.

PR validation:

Manually validated by running the displaced-particle-gun workflows and checking the resulting HGCal validation plots.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

This PR is part of a summer student project under the supervision of @bfonta.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51510/50260

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Particle Flow cluster validation in ECAL #50292, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51510/50260/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51510/50260/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51510/50261

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Particle Flow cluster validation in ECAL #50292, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047

[cmsbuild]

Pull request #51510 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please check and sign again.

[gabrielmscampos]

please test

[cmsbuild]

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d8e23/54853/summary.html
COMMIT: bf7f776
CMSSW: CMSSW_20_1_X_2026-07-21-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51510/54853/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3792541
• DQMHistoTests: Total failures: 60
• DQMHistoTests: Total nulls: 144
• DQMHistoTests: Total successes: 3792319
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2381.8030000000003 KiB( 46 files compared)
• DQMHistoSizes: changed ( 34434.0,... ): 249.128 KiB HLT/HGCAL
• DQMHistoSizes: changed ( 34434.0,... ): 177.407 KiB HGCAL/HGCalValidator
• Checked 203 log files, 173 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[gabrielmscampos]

+dqm

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

+1