Fix customiseTrackingNtuple.extendedContent to correctly pick up OOT particles#51461
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51461/50151 |
|
A new Pull Request was created by @slava77 for master. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 24KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
Are the differences in the DQM comparison (in the |
I think these are coming from the other commits that got merged together:
|
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
It looks like I introduced a bug in #48881 in the extendedContent diffs
The code changes there were intentionally meant to pick up out-of-time pileup, but one component was missing.
This PR is a fix (tested on a somewhat random PU200 setup)
std::exception was thrown. unordered_map::at, which can happen after a few events.@bdanzi @VourMa I think you mentioned some setup not working with the
extendedContentpossibly related to this; I can't recall if you found another work-around.