Skip to content

Fix customiseTrackingNtuple.extendedContent to correctly pick up OOT particles#51461

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
slava77:patch-506067
Jul 10, 2026
Merged

Fix customiseTrackingNtuple.extendedContent to correctly pick up OOT particles#51461
cmsbuild merged 1 commit into
cms-sw:masterfrom
slava77:patch-506067

Conversation

@slava77

@slava77 slava77 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

It looks like I introduced a bug in #48881 in the extendedContent diffs
The code changes there were intentionally meant to pick up out-of-time pileup, but one component was missing.

This PR is a fix (tested on a somewhat random PU200 setup)

  • the symptoms without a fix is a crash with std::exception was thrown. unordered_map::at, which can happen after a few events.

@bdanzi @VourMa I think you mentioned some setup not working with the extendedContent possibly related to this; I can't recall if you found another work-around.

@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @slava77 for master.

It involves the following packages:

  • Validation/RecoTrack (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @mmasciov, @mmusich, @mtosi, @rovere, @wmtford this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@slava77

slava77 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@slava77 slava77 changed the title Change intimeOnly to False in customiseTrackingNtuple.extendedContent to correctly pick up OOT particles Fix customiseTrackingNtuple.extendedContent to correctly pick up OOT particles Jul 9, 2026
@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df965d/54653/summary.html
COMMIT: cd14772
CMSSW: CMSSW_20_1_X_2026-07-09-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51461/54653/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df965d/54653/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df965d/54653/git-merge-result

Comparison Summary

Summary:

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step2 max memory diff 33.3 exceeds +/- 30.0 MiB

@gabrielmscampos

Copy link
Copy Markdown
Member

Are the differences in the DQM comparison (in the HLT/ bit) along the expectation?

@mmusich

mmusich commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Are the differences in the DQM comparison (in the HLT/ bit) along the expectation?

I think these are coming from the other commits that got merged together:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@gabrielmscampos

Copy link
Copy Markdown
Member

+dqm

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit ee7bb90 into cms-sw:master Jul 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants