Skip to content

mkfit for LST-seeded in offline phase-2#51140

Merged
cmsbuild merged 4 commits into
cms-sw:masterfrom
SegmentLinking:bdanzi_mkfit_LSTseeded_pre2
Jun 30, 2026
Merged

mkfit for LST-seeded in offline phase-2#51140
cmsbuild merged 4 commits into
cms-sw:masterfrom
SegmentLinking:bdanzi_mkfit_LSTseeded_pre2

Conversation

@bdanzi

@bdanzi bdanzi commented Jun 8, 2026

Copy link
Copy Markdown

PR description:

This PR enables via the procModifiers combination trackingMkFitHighPtTripletStep & seedingLST & trackingLST the usage of mkFit track building after LST seeds and legacy pixel triplets and quadruplets, in a baseline HLT-like configuration.
It depends on the external PR RecoTracker-MkFit/pull/20.

PR validation:

Configuration tested for CMS week contributions June 2026 https://indico.cern.ch/event/1690107/#93-study-on-offline-track-reco and https://indico.cern.ch/event/1690107/#93-study-on-offline-track-reco

This PR can be tested, e.g., with workflows 36034.711,36034.712,36034.713 that are using the corresponding procModifiers in an offline tracking-only workflow.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No

@mmasciov @slava77

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51140/49660

@slava77

slava77 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

test parameters:

@slava77

slava77 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild please test

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_20_1_X. Please open a backport if it should also go in to CMSSW_20_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_20_0_X, CMSSW_20_1_X Jun 9, 2026
@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e95f48/53759/summary.html
COMMIT: dc618f2
CMSSW: CMSSW_20_0_X_2026-06-08-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51140/53759/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

ValueError: Undefined workflows: 29634.7571

@jfernan2

jfernan2 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

test parameters:

@jfernan2

jfernan2 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

please test

@gabrielmscampos

Copy link
Copy Markdown
Member

test parameters:

@gabrielmscampos

Copy link
Copy Markdown
Member

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e95f48/54243/summary.html
COMMIT: 4b8392e
CMSSW: CMSSW_20_1_X_2026-06-23-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51140/54243/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e95f48/54243/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e95f48/54243/git-merge-result

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3648276
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3648258
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 203 log files, 173 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@slava77

slava77 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

pull_request = Add JSON for LST-seeded iteration (phase-2 offline) cms-data/RecoTracker-MkFit#20

this PR was merged last week; so this test parameter is not needed.

I suspect that The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: is from this still remaining parameter (the base commits in this PR is CMSSW_20_1_X_2026-06-21-2300, so, there should be no need for more recent commits).
@smuzaffar is it practical to have a check of the external requirements from the test parameters (if they are already in the IB) so that they are effectively ignored, or is it better to hand-edit the parameters?

@smuzaffar

Copy link
Copy Markdown
Contributor

@smuzaffar is it practical to have a check of the external requirements from the test parameters (if they are already in the IB) so that they are effectively ignored, or is it better to hand-edit the parameters?

@slava77 , I think we need some indication that for a PR there was a dependnecy on another PR . This is useful when someone wants to backport the PR ( extra label with different color give you such a hint :-)

@slava77

slava77 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@slava77 , I think we need some indication that for a PR there was a dependnecy on another PR . This is useful when someone wants to backport the PR ( extra label with different color give you such a hint :-)

Thanks for clarifying. If it's beneficial for just having a label, it's fine.
However, presence of an external PR requirement (usually?) lead to a cms-bot build from the head instead of from the IB, which may trigger unrelated PRs included as well as unrelated diffs in comparisons. (Here, did I interpret correctly that the addition of cmsdist#10680 on top of CMSSW_20_1_X_2026-06-23-2300 was an effect of the still present external PR requirement?)

@smuzaffar

Copy link
Copy Markdown
Contributor

Thanks for clarifying. If it's beneficial for just having a label, it's fine. However, presence of an external PR requirement (usually?) lead to a cms-bot build from the head instead of from the IB, which may trigger unrelated PRs included as well as unrelated diffs in comparisons.

OK, I see what you mean. I will check if we can avoid skipping the addtional external (cmsdist and may be cms-data) PRs if they are already in the IB used by bot for the tests.

Here, did I interpret correctly that the addition of cmsdist#10680 on top of CMSSW_20_1_X_2026-06-23-2300 was an effect of the still present external PR requirement?)

No, it was because the test paramters explicitly requested the addtion of cmsdist#10680.

@slava77

slava77 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

this PR was merged last week; so this test parameter is not needed.

just to be clear, the discussion following my comment above is technical, related to how I thought the cms-bot tests may need to be updated. The tests for the PR from 2 days ago should be fine.

@gabrielmscampos

Copy link
Copy Markdown
Member

+dqm

@jfernan2

Copy link
Copy Markdown
Contributor

+1

@AdrianoDee

Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit ce1079e into cms-sw:master Jun 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants