MTD Geometry: clean compiler warnings

[fabiocos]

PR description:

MTDDetId and MTDGeometry show compiler warnings about const declaration being useless, and they propagate to all dependencies. This PR cleans the issue.

PR validation:

Code compiles, and wf. 34434.0 runs smoothly.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51127/49644

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/ForwardDetId/interface/MTDDetId.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51127/49644/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51127/49644/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51127/49645

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/ForwardDetId/interface/MTDDetId.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• DataFormats/ForwardDetId (simulation)
• Geometry/MTDGeometryBuilder (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @denizsun, @martinamalberti, @missirol, @mmusich, @rovere, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

[fabiocos]

please test

[makortel]

(I assume this PR does not need a backport to 17_0_X (Run 3 legacy))

[fabiocos]

@makortel absolutely not, and its integration is not urgent. But since the warnings are quite annoying when doing concurrent developments, I have prepared it before forgetting. It may enter with calm after your work on 20_0_X.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51127/49740

[cmsbuild]

Pull request #51127 was updated. @Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27d813/53899/summary.html
COMMIT: 47cc05c
CMSSW: CMSSW_20_1_X_2026-06-12-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51127/53899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3267025
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3267007
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 159 edm output root files, 44 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1