Phase2 L1T: Correlator development for AR2026 by cerminar · Pull Request #51093 · cms-sw/cmssw

cerminar · 2026-05-29T14:49:31Z

PR description:

Port recent Correlator development to master.

For now:

SeededCone-8 2-Prong Jet Model (L1TSC82ProngJetModel p2l1pfp/cmssw#150)
Unse TMUX18 Layer-1 configuration consistently across the emulation chain (Move default config to TMUX18 and drop TMUX6 modules for binary file creation p2l1pfp/cmssw#155)

PR validation:

Ongoing...

* Added nprong score to DataFormats. * Added L1TSC82ProngJet to DPGAnalysis. * Added L1TSC82ProngJetModel to L1Trigger/Phase2L1ParticleFlow * Fix for nprong tag. * Cleaned includes. * File renamed. * Removed comment from addPh2GTObjects(process) * fixes. * Reverted changes. * Removed cuts.. * Update L1Trigger/Phase2L1ParticleFlow/src/L1TSC82ProngJetID.cc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update L1Trigger/Phase2L1ParticleFlow/plugins/L1TSC82ProngJetModelProducer.cc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update DataFormats/L1TParticleFlow/src/jets.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added values for minPt and maxEta. * Added std headers. * Added a check for fNParticles. * Update L1Trigger/Phase2L1ParticleFlow/python/l1pfJetMet_cff.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply CMSSW code-format --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

cmsbuild · 2026-05-29T14:50:01Z

cms-bot internal usage

cmsbuild · 2026-05-29T14:51:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51093/49576

There are other open Pull requests which might conflict with changes you have proposed:
- File DPGAnalysis/Phase2L1TNanoAOD/python/l1tPh2Nanotables_cff.py modified in PR(s): [Not to merge] Update L1TPh2 ntuple sequence and eventcontent #49477
- File DataFormats/L1TParticleFlow/interface/jets.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
- File DataFormats/L1TParticleFlow/src/jets.cpp modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968

quinnanm · 2026-06-02T01:03:22Z

please test

cmsbuild · 2026-06-02T01:03:42Z

A new Pull Request was created by @cerminar for master.

It involves the following packages:

DPGAnalysis/Phase2L1TNanoAOD (l1, xpog)
DataFormats/L1TParticleFlow (l1)
L1Trigger/Phase2L1ParticleFlow (l1)

@BenjaminRS, @battibass, @ftorrresd, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2026-06-02T05:22:39Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f83587/53637/summary.html
COMMIT: 8f89e86
CMSSW: CMSSW_17_0_X_2026-06-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51093/53637/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34434.911

----- Begin Fatal Exception 02-Jun-2026 04:02:26 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1TCtL2EgProducer/'l1tLayer2EGElliptic'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: l1t::RegionalOutput<std::vector<l1t::TkElectron> >
Looking for module label: l1tLayer1BarrelElliptic
Looking for productInstanceName: L1TkElePerBoard

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 02-Jun-2026 03:53:38 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1TCtL2EgProducer/'l1tLayer2EGElliptic'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: l1t::RegionalOutput<std::vector<l1t::TkElectron> >
Looking for module label: l1tLayer1BarrelElliptic
Looking for productInstanceName: L1TkElePerBoard

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34434.75

----- Begin Fatal Exception 02-Jun-2026 03:54:03 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1TCtL2EgProducer/'l1tLayer2EGElliptic'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: l1t::RegionalOutput<std::vector<l1t::TkElectron> >
Looking for module label: l1tLayer1BarrelElliptic
Looking for productInstanceName: L1TkElePerBoard

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

cmsbuild · 2026-06-05T16:38:11Z

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

makortel · 2026-06-05T18:26:36Z

(I assume this PR does not need a backport to 17_0_X (Run 3 legacy))

cerminar · 2026-06-08T13:59:44Z

(I assume this PR does not need a backport to 17_0_X (Run 3 legacy))

I am actually not sure: @quinnanm @BenjaminRS what is the release we target for the AR2026 studies?
Cheers!

…CTL2

cmsbuild · 2026-06-19T10:01:36Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51093/49852

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51093/49852/cms-checkout-topic.log

cerminar · 2026-06-19T13:10:19Z

Quite funny: all of the changes to dataformats will conflict because of indentation. Not to mention the fact that the namespace is in the classdef....

@makortel do you have automated tools to handle the port to 20.1?

please advise.

makortel · 2026-06-19T15:23:18Z

Unfortunately we don't have automated migration tools. You need to rebase on top of e.g. CMSSW_20_0_0_pre1 (or any 20_1_X IB), and resolve the conflicts. The differences in classes_def.xml files need to be resolved explicitly, indentation differences can be left for scram b code-format.

makortel · 2026-06-19T15:24:19Z

If the commit history is not important, the conflict resolution would be easiest with all commits squashed to one (or squashed to a few commits if the history is important).

cmsbuild · 2026-06-22T09:39:44Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51093/49879

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51093/49879/cms-checkout-topic.log

henripetrow and others added 2 commits May 29, 2026 11:25

TM18 is now the default configuration for all serenity modules

8f89e86

cmsbuild added this to the CMSSW_17_0_X milestone May 29, 2026

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels May 29, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 29, 2026

cerminar marked this pull request as ready for review June 1, 2026 13:51

cmsbuild added tests-started and removed tests-pending labels Jun 2, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 2, 2026

cmsbuild modified the milestones: CMSSW_17_0_X, CMSSW_20_0_X Jun 5, 2026

jmitrevs and others added 10 commits June 18, 2026 16:13

automatic scram code-format checks

44b23ca

update comments to be correct, remove unneeded include

32c6722

Futher fix for GCT Had calibration

3a4791c

updated with calibration bugfix

a2534f6

corrections using pt02 as reference

4d2ce58

tweak tkele EB WP

ee47009

rounding to HW values

f16ec01

code-checks

d585748

Added EM barrel calibs & implementation of the tkele pt regression @ …

5800c3d

…CTL2

add pset descriptions

a9c75a9

cmsbuild added tests-pending code-checks-pending changes-dataformats and removed tests-rejected code-checks-approved labels Jun 19, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 19, 2026

cerminar mentioned this pull request Jun 19, 2026

Phase2 L1T: Correlator development for AR2026 #51270

Open

cerminar added 2 commits June 22, 2026 11:37

codeformat

d43a9d8

codeformat NNVTX

8975514

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 22, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 22, 2026

cerminar closed this Jun 22, 2026

Uh oh!

Conversation

cerminar commented May 29, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 29, 2026

Uh oh!

quinnanm commented Jun 2, 2026

Uh oh!

cmsbuild commented Jun 2, 2026

Uh oh!

cmsbuild commented Jun 2, 2026

Failed RelVals

Uh oh!

cmsbuild commented Jun 5, 2026

Uh oh!

makortel commented Jun 5, 2026

Uh oh!

cerminar commented Jun 8, 2026

Uh oh!

cmsbuild commented Jun 19, 2026

Uh oh!

cerminar commented Jun 19, 2026

Uh oh!

makortel commented Jun 19, 2026

Uh oh!

makortel commented Jun 19, 2026

Uh oh!

cmsbuild commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

cmsbuild commented May 29, 2026 •

edited

Loading