[RECONSTRUCTION] Drop Geometry/CommonDetUnit package

[smuzaffar]

In order to avoid cyclic dependency (#28415) we had merged Geometry/CommonDetUnit in to Geometry/CommonTopologies (#28500) . This PR is to cleanup the usage of Geometry/CommonDetUnit

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51076/49529

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/TrackerRecHit2D/BuildFile.xml modified in PR(s): BuildFile dependency cleaning, 1st round #50916
  • File DataFormats/TrackerRecHit2D/interface/BaseTrackerRecHit.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
  • File DataFormats/TrackerRecHit2D/interface/TrackerSingleRecHit.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
  • File DataFormats/TrackingRecHit/BuildFile.xml modified in PR(s): BuildFile dependency cleaning, 1st round #50916
  • File DataFormats/TrackingRecHit/interface/TrackingRecHit.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
  • File RecoEgamma/EgammaIsolationAlgos/interface/EgammaHLTTrackIsolation.h modified in PR(s): Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007
  • File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): Add directories for TICL-EGM code development #48319, [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
  • File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319, TICL-barrel: 3D Pattern recognition in the barrel #50551, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File RecoHGCal/TICL/plugins/TracksterLinkingbySkeletons.h modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoHGCal/TICL/plugins/TracksterLinksProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoHI/HiCentralityAlgos/plugins/CentralityProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoLocalMuon/RPCRecHit/plugins/DTSegtoRPC.cc modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
  • File RecoMuon/DetLayers/src/MuRingForwardDoubleLayer.cc modified in PR(s): Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 #47138
  • File RecoMuon/DetLayers/src/MuonRPCDetLayerGeometryBuilder.cc modified in PR(s): Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 #47138
  • File RecoMuon/MuonIdentification/plugins/GlobalMuonToMuonProducer.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
  • File RecoMuon/MuonIdentification/plugins/MuonProducer.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
  • File RecoMuon/TransientTrackingRecHit/plugins/MuonTransientTrackingRecHitBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoTracker/FinalTrackSelectors/plugins/BuildFile.xml modified in PR(s): [NGT] DNN for HP Pixel track selection #51042
  • File TrackingTools/PatternTools/BuildFile.xml modified in PR(s): BuildFile dependency cleaning, 1st round #50916
  • File TrackingTools/TransientTrack/BuildFile.xml modified in PR(s): BuildFile dependency cleaning, 1st round #50916
  • File TrackingTools/TransientTrack/plugins/TransientTrackBuilderESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File TrackingTools/TransientTrackingRecHit/BuildFile.xml modified in PR(s): BuildFile dependency cleaning, 1st round #50916

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• CommonTools/RecoAlgos (reconstruction)
• CommonTools/Utils (reconstruction)
• DataFormats/TrackerRecHit2D (reconstruction)
• DataFormats/TrackingRecHit (reconstruction)
• EventFilter/SiPixelRawToDigi (reconstruction)
• RecoBTag/PixelCluster (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoEgamma/EgammaPhotonAlgos (reconstruction)
• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoHGCal/TICL (reconstruction)
• RecoHI/HiCentralityAlgos (reconstruction)
• RecoHI/HiTracking (reconstruction)
• RecoJets/JetProducers (reconstruction)
• RecoLocalFastTime/FTLClusterizer (reconstruction)
• RecoLocalFastTime/FTLCommonAlgos (reconstruction)
• RecoLocalMuon/CSCEfficiency (reconstruction)
• RecoLocalMuon/CSCValidation (reconstruction)
• RecoLocalMuon/DTSegment (reconstruction)
• RecoLocalMuon/GEMCSCSegment (reconstruction)
• RecoLocalMuon/GEMRecHit (reconstruction)
• RecoLocalMuon/RPCRecHit (reconstruction)
• RecoLocalTracker/ClusterParameterEstimator (reconstruction)
• RecoLocalTracker/Phase2TrackerRecHits (reconstruction)
• RecoLocalTracker/SiPhase2Clusterizer (reconstruction)
• RecoLocalTracker/SiPhase2VectorHitBuilder (reconstruction)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoLocalTracker/SiStripRecHitConverter (reconstruction)
• RecoLocalTracker/SubCollectionProducers (reconstruction)
• RecoLuminosity/LumiProducer (reconstruction)
• RecoMET/METAlgorithms (reconstruction)
• RecoMET/METProducers (reconstruction)
• RecoMTD/DetLayers (reconstruction)
• RecoMTD/TransientTrackingRecHit (reconstruction)
• RecoMuon/CosmicMuonProducer (reconstruction)
• RecoMuon/DetLayers (reconstruction)
• RecoMuon/GlobalMuonProducer (reconstruction)
• RecoMuon/GlobalTrackingTools (reconstruction)
• RecoMuon/MuonIdentification (reconstruction)
• RecoMuon/MuonSeedGenerator (reconstruction)
• RecoMuon/StandAloneMuonProducer (reconstruction)
• RecoMuon/StandAloneTrackFinder (reconstruction)
• RecoMuon/TrackerSeedGenerator (reconstruction)
• RecoMuon/TrackingTools (reconstruction)
• RecoMuon/TransientTrackingRecHit (reconstruction)
• RecoParticleFlow/PFSimProducer (reconstruction)
• RecoParticleFlow/PFTracking (reconstruction)
• RecoTracker/ConversionSeedGenerators (reconstruction)
• RecoTracker/DeDx (reconstruction)
• RecoTracker/DebugTools (reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/LST (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)
• RecoTracker/PixelLowPtUtilities (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)
• RecoTracker/PixelTrackFitting (reconstruction)
• RecoTracker/SiTrackerMRHTools (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• RecoTracker/TkDetLayers (reconstruction)
• RecoTracker/TkMSParametrization (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)
• RecoTracker/TkSeedingLayers (reconstruction)
• RecoTracker/TrackProducer (reconstruction)
• RecoTracker/TransientTrackingRecHit (reconstruction)
• RecoVertex/V0Producer (reconstruction)
• TrackPropagation/SteppingHelixPropagator (reconstruction)
• TrackingTools/DetLayers (reconstruction)
• TrackingTools/GsfTools (reconstruction)
• TrackingTools/KalmanUpdators (reconstruction)
• TrackingTools/MeasurementDet (reconstruction)
• TrackingTools/PatternTools (reconstruction)
• TrackingTools/TrackAssociator (reconstruction)
• TrackingTools/TrackRefitter (reconstruction)
• TrackingTools/TrajectoryState (reconstruction)
• TrackingTools/TransientTrack (reconstruction)
• TrackingTools/TransientTrackingRecHit (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @afiqaize, @ahinzmann, @alesaggio, @amagitte, @andrzejnovak, @apsallid, @argiro, @battibass, @bellan, @castaned, @cericeci, @clelange, @denizsun, @dgulhan, @dkotlins, @echabert, @elusian, @fabiocos, @felicepantaleo, @ferencek, @forthommel, @fsimone91, @gbenelli, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jainshilpi, @jazzitup, @jdamgov, @jdolen, @jhgoh, @jlidrych, @jshlee, @kurtejung, @lecriste, @lgray, @llunerti, @mandrenguyen, @mariadalfonso, @martinamalberti, @missirol, @mmarionncern, @mmasciov, @mmusich, @mroguljic, @mtosi, @nhanvtran, @pavlo-kashko, @philippgadow, @ptcox, @ram1123, @rappoccio, @rchatter, @robervalwalsh, @rociovilar, @rovere, @salimcerci, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @thomreis, @threus, @trocino, @tsusa, @valsdav, @varuns23, @wang0jin, @watson-ij, @yenjie, @yetkinyilmaz, @yslai this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Size: This PR adds an extra 1012KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0453f1/53534/summary.html
COMMIT: 685f036
CMSSW: CMSSW_17_0_X_2026-05-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51076/53534/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 55
• DQMHistoTests: Total histograms compared: 4432276
• DQMHistoTests: Total failures: 27
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4432229
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
• Checked 235 log files, 207 edm output root files, 55 DQM output files
• TriggerResults: no differences found

[Moanwar]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1