Skip to content

[bugfix] Force HFNose pattern recognition to use CA#51048

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
felicepantaleo:nosejob
May 27, 2026
Merged

[bugfix] Force HFNose pattern recognition to use CA#51048
cmsbuild merged 1 commit into
cms-sw:masterfrom
felicepantaleo:nosejob

Conversation

@felicepantaleo

Copy link
Copy Markdown
Contributor

PR #49932 switched default TICL Pattern Recognition to CLUE3D.
However, the unmaintained HFNose reconstruction should still be using CA as per TICLv3.

This PR fixes the issue #51017

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

type bugfix

@cmsbuild

cmsbuild commented May 27, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test workflow 32034.0

@felicepantaleo felicepantaleo changed the title Force HFNose pattern recognition to use CA [bugfix] Force HFNose pattern recognition to use CA May 27, 2026
@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • RecoHGCal/TICL (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @forthommel, @hatakeyamak, @lecriste, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7b54e/53503/summary.html
COMMIT: 32bd6d9
CMSSW: CMSSW_17_0_X_2026-05-26-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51048/53503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
32034.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198427
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 230 log files, 199 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@Moanwar

Moanwar commented May 27, 2026

Copy link
Copy Markdown
Contributor

+1

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 26ea38c into cms-sw:master May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants