Skip to content

Add MPI modules to different paths in the splitter#50821

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
Annnnya:splitter_fixes
Apr 28, 2026
Merged

Add MPI modules to different paths in the splitter#50821
cmsbuild merged 2 commits into
cms-sw:masterfrom
Annnnya:splitter_fixes

Conversation

@Annnnya

@Annnnya Annnnya commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

PR description:

This pr modifies edmMpiSplitConfig to add MPI modules to different paths depending on their group. It also copies MessageLogger into remote configuration.

@cmsbuild

cmsbuild commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Annnnya for master.

It involves the following packages:

  • HeterogeneousCore/MPICore (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Comment thread HeterogeneousCore/MPICore/python/configuration_splitter/split_remote.py Outdated
@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #50821 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

@fwyzard

fwyzard commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

please test

@fwyzard

fwyzard commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

+heterogeneous

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard

fwyzard commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

The unit test failure

OSError: Input folder '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02939/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-04-27-2300/external/el8_amd64_gcc13/data/DQM/Integration/data/run402360' does not exist in CMSSW_SEARCH_PATH

is pretty much unrelated to this PR.

@fwyzard

fwyzard commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

ignore tests-rejected with external-failure

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eff780/52914/summary.html
COMMIT: f70b784
CMSSW: CMSSW_17_0_X_2026-04-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50821/52914/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eff780/52914/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eff780/52914/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOnlineClient-ngt_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4186963
  • DQMHistoTests: Total failures: 28
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4186915
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@ftenchini

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit a22bd2e into cms-sw:master Apr 28, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants