Skip to content

update SherpaHardronizer for HepMC3#50591

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
shimashimarin:master
Apr 21, 2026
Merged

update SherpaHardronizer for HepMC3#50591
cmsbuild merged 1 commit into
cms-sw:masterfrom
shimashimarin:master

Conversation

@shimashimarin

Copy link
Copy Markdown
Contributor

PR description:

Add SherpaHepMC3Hadronizer.cc to be compatible with HepMC3. The latest Sherpa 2.2.16 is compiled with HepMC3 link.

PR validation:

Local test with DY@LO have been performed plots. The functionality works.

NOTE:

@cmsbuild

cmsbuild commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @shimashimarin for master.

It involves the following packages:

  • GeneratorInterface/SherpaInterface (generators)

@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano, @thuer this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

cmsbuild commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bc153/52407/summary.html
COMMIT: 2360896
CMSSW: CMSSW_16_1_X_2026-04-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50591/52407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180749
  • DQMHistoTests: Total failures: 67
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4180662
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@cmsbuild

cmsbuild commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_16_1_X, CMSSW_17_0_X Apr 4, 2026
@lviliani

Copy link
Copy Markdown
Contributor

+generators

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini

Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 3e4530a into cms-sw:master Apr 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants