-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add an MPISenderPortable and MPIReceiverPortable modules to send/receive arbitrary device collections
#50503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghyls
wants to merge
4
commits into
cms-sw:master
Choose a base branch
from
ghyls:devel-mpi-generic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
61aa03f
Enable the registration at runtime of DtoH and HtoD product transform…
ghyls 72f4917
Add tests for typed limited transformers and for untyped global, stre…
ghyls 93649d9
Add MPI Sender and Receiver modules that support arbitrary device col…
ghyls 416cf97
Enable CUDA/ROCm-aware MPI
ghyls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #include "DataFormats/BeamSpot/interface/BeamSpotHost.h" | ||
| #include "DataFormats/BeamSpot/interface/alpaka/BeamSpotDevice.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(BeamSpotDevice); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(BeamSpotHost, BeamSpotDevice); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| #include "DataFormats/EcalDigi/interface/EcalDigiHostCollection.h" | ||
| #include "DataFormats/EcalDigi/interface/EcalDigiPhase2HostCollection.h" | ||
| #include "DataFormats/EcalDigi/interface/alpaka/EcalDigiDeviceCollection.h" | ||
| #include "DataFormats/EcalDigi/interface/alpaka/EcalDigiPhase2DeviceCollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(EcalDigiDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(EcalDigiPhase2DeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(EcalDigiHostCollection, EcalDigiDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(EcalDigiPhase2HostCollection, EcalDigiPhase2DeviceCollection); |
6 changes: 4 additions & 2 deletions
6
DataFormats/EcalRecHit/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| #include "DataFormats/EcalRecHit/interface/EcalRecHitHostCollection.h" | ||
| #include "DataFormats/EcalRecHit/interface/EcalUncalibratedRecHitHostCollection.h" | ||
| #include "DataFormats/EcalRecHit/interface/alpaka/EcalRecHitDeviceCollection.h" | ||
| #include "DataFormats/EcalRecHit/interface/alpaka/EcalUncalibratedRecHitDeviceCollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(EcalRecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(EcalUncalibratedRecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(EcalRecHitHostCollection, EcalRecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(EcalUncalibratedRecHitHostCollection, EcalUncalibratedRecHitDeviceCollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| #include "DataFormats/HGCalDigi/interface/HGCalDigiHost.h" | ||
| #include "DataFormats/HGCalDigi/interface/HGCalECONDPacketInfoHost.h" | ||
| #include "DataFormats/HGCalDigi/interface/HGCalFEDPacketInfoHost.h" | ||
| #include "DataFormats/HGCalDigi/interface/alpaka/HGCalDigiDevice.h" | ||
| #include "DataFormats/HGCalDigi/interface/alpaka/HGCalECONDPacketInfoDevice.h" | ||
| #include "DataFormats/HGCalDigi/interface/alpaka/HGCalFEDPacketInfoDevice.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(hgcaldigi::HGCalDigiDevice); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(hgcaldigi::HGCalECONDPacketInfoDevice); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(hgcaldigi::HGCalFEDPacketInfoDevice); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(hgcaldigi::HGCalDigiHost, hgcaldigi::HGCalDigiDevice); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(hgcaldigi::HGCalECONDPacketInfoHost, hgcaldigi::HGCalECONDPacketInfoDevice); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(hgcaldigi::HGCalFEDPacketInfoHost, hgcaldigi::HGCalFEDPacketInfoDevice); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| #include "DataFormats/HGCalReco/interface/HGCalSoAClustersHostCollection.h" | ||
| #include "DataFormats/HGCalReco/interface/HGCalSoARecHitsExtraHostCollection.h" | ||
| #include "DataFormats/HGCalReco/interface/HGCalSoARecHitsHostCollection.h" | ||
| #include "DataFormats/HGCalReco/interface/alpaka/HGCalSoAClustersDeviceCollection.h" | ||
| #include "DataFormats/HGCalReco/interface/alpaka/HGCalSoARecHitsExtraDeviceCollection.h" | ||
| #include "DataFormats/HGCalReco/interface/alpaka/HGCalSoARecHitsDeviceCollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(HGCalSoAClustersDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(HGCalSoARecHitsExtraDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(HGCalSoARecHitsDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(HGCalSoAClustersHostCollection, HGCalSoAClustersDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(HGCalSoARecHitsExtraHostCollection, HGCalSoARecHitsExtraDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(HGCalSoARecHitsHostCollection, HGCalSoARecHitsDeviceCollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| #include "DataFormats/HcalDigi/interface/HcalDigiHostCollection.h" | ||
| #include "DataFormats/HcalDigi/interface/alpaka/HcalDigiDeviceCollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(hcal::Phase0DigiDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(hcal::Phase1DigiDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(hcal::Phase0DigiHostCollection, hcal::Phase0DigiDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(hcal::Phase1DigiHostCollection, hcal::Phase1DigiDeviceCollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #include "DataFormats/HcalRecHit/interface/HcalRecHitHostCollection.h" | ||
| #include "DataFormats/HcalRecHit/interface/alpaka/HcalRecHitDeviceCollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(hcal::RecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(hcal::RecHitHostCollection, hcal::RecHitDeviceCollection); |
12 changes: 8 additions & 4 deletions
12
DataFormats/ParticleFlowReco/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,17 @@ | ||
| // Include the Eigen core library before including the SoA definitions | ||
| #include <Eigen/Core> | ||
|
|
||
| #include "DataFormats/ParticleFlowReco/interface/CaloRecHitHostCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/PFClusterHostCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/PFRecHitFractionHostCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/PFRecHitHostCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/alpaka/CaloRecHitDeviceCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/alpaka/PFClusterDeviceCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/alpaka/PFRecHitFractionDeviceCollection.h" | ||
| #include "DataFormats/ParticleFlowReco/interface/alpaka/PFRecHitDeviceCollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::CaloRecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::PFClusterDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::PFRecHitFractionDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::PFRecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::CaloRecHitHostCollection, reco::CaloRecHitDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::PFClusterHostCollection, reco::PFClusterDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::PFRecHitFractionHostCollection, reco::PFRecHitFractionDeviceCollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::PFRecHitHostCollection, reco::PFRecHitDeviceCollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
DataFormats/SiPixelClusterSoA/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #include "DataFormats/SiPixelClusterSoA/interface/SiPixelClustersHost.h" | ||
| #include "DataFormats/SiPixelClusterSoA/interface/alpaka/SiPixelClustersSoACollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(SiPixelClustersSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(SiPixelClustersHost, SiPixelClustersSoACollection); |
6 changes: 4 additions & 2 deletions
6
DataFormats/SiPixelDigiSoA/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| #include "DataFormats/SiPixelDigiSoA/interface/SiPixelDigiErrorsHost.h" | ||
| #include "DataFormats/SiPixelDigiSoA/interface/SiPixelDigisHost.h" | ||
| #include "DataFormats/SiPixelDigiSoA/interface/alpaka/SiPixelDigiErrorsSoACollection.h" | ||
| #include "DataFormats/SiPixelDigiSoA/interface/alpaka/SiPixelDigisSoACollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(SiPixelDigiErrorsSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(SiPixelDigisSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(SiPixelDigiErrorsHost, SiPixelDigiErrorsSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(SiPixelDigisHost, SiPixelDigisSoACollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <library file="TrivialSerialisation.cc" name="DataFormatsSiStripClusterSoATrivialSerialisation"> | ||
| <use name="DataFormats/SiStripClusterSoA"/> | ||
| <use name="HeterogeneousCore/TrivialSerialisation"/> | ||
| <flags EDM_PLUGIN="1"/> | ||
| </library> | ||
|
|
||
| <library file="alpaka/TrivialSerialisation.cc" name="DataFormatsSiStripClusterSoATrivialSerialisationPortable"> | ||
| <use name="DataFormats/SiStripClusterSoA"/> | ||
| <use name="HeterogeneousCore/TrivialSerialisation"/> | ||
| <flags ALPAKA_BACKENDS="1"/> | ||
| <flags EDM_PLUGIN="1"/> | ||
| </library> |
4 changes: 4 additions & 0 deletions
4
DataFormats/SiStripClusterSoA/plugins/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #include "DataFormats/SiStripClusterSoA/interface/SiStripClusterHost.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/SerialiserFactory.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN(sistrip::SiStripClusterHost); |
5 changes: 5 additions & 0 deletions
5
DataFormats/SiStripClusterSoA/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #include "DataFormats/SiStripClusterSoA/interface/SiStripClusterHost.h" | ||
| #include "DataFormats/SiStripClusterSoA/interface/alpaka/SiStripClusterDevice.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(sistrip::SiStripClusterHost, sistrip::SiStripClusterDevice); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <library file="TrivialSerialisation.cc" name="DataFormatsSiStripDigiSoATrivialSerialisation"> | ||
| <use name="DataFormats/SiStripDigiSoA"/> | ||
| <use name="HeterogeneousCore/TrivialSerialisation"/> | ||
| <flags EDM_PLUGIN="1"/> | ||
| </library> | ||
|
|
||
| <library file="alpaka/TrivialSerialisation.cc" name="DataFormatsSiStripDigiSoATrivialSerialisationPortable"> | ||
| <use name="DataFormats/SiStripDigiSoA"/> | ||
| <use name="HeterogeneousCore/TrivialSerialisation"/> | ||
| <flags ALPAKA_BACKENDS="1"/> | ||
| <flags EDM_PLUGIN="1"/> | ||
| </library> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #include "DataFormats/SiStripDigiSoA/interface/SiStripDigiHost.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/SerialiserFactory.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN(sistrip::SiStripDigiHost); |
5 changes: 5 additions & 0 deletions
5
DataFormats/SiStripDigiSoA/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #include "DataFormats/SiStripDigiSoA/interface/SiStripDigiHost.h" | ||
| #include "DataFormats/SiStripDigiSoA/interface/alpaka/SiStripDigiDevice.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(sistrip::SiStripDigiHost, sistrip::SiStripDigiDevice); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #include "DataFormats/TrackSoA/interface/TracksHost.h" | ||
| #include "DataFormats/TrackSoA/interface/alpaka/TracksSoACollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::TracksSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::TracksHost, reco::TracksSoACollection); |
3 changes: 2 additions & 1 deletion
3
DataFormats/TrackingRecHitSoA/plugins/alpaka/TrivialSerialisation.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #include "DataFormats/TrackingRecHitSoA/interface/TrackingRecHitsHost.h" | ||
| #include "DataFormats/TrackingRecHitSoA/interface/alpaka/TrackingRecHitsSoACollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::TrackingRecHitsSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::TrackingRecHitHost, reco::TrackingRecHitsSoACollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #include "DataFormats/VertexSoA/interface/ZVertexHost.h" | ||
| #include "DataFormats/VertexSoA/interface/alpaka/ZVertexSoACollection.h" | ||
| #include "HeterogeneousCore/TrivialSerialisation/interface/alpaka/SerialiserFactoryDevice.h" | ||
|
|
||
| DEFINE_TRIVIAL_SERIALISER_PLUGIN_DEVICE(reco::ZVertexSoACollection); | ||
| DEFINE_TRIVIAL_SERIALISER_PORTABLE_PLUGIN(reco::ZVertexHost, reco::ZVertexSoACollection); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend this overload to the other module base classes that provide Transformer (that is,
globalandlimited).The real test suite for the Transformer is in
cmssw/FWCore/Integration/test/BuildFile.xml
Lines 60 to 78 in bd607fa
Could you extend those to cover this overload as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see! Thank you. I extended the overload to the
globalandlimitedimplementors.hTo test the untyped
registerTransformAsync, I added twoFWCore/Integration/plugins:TransformAsyncIntUntypedProducer.cc, based onTransformAsyncIntProducer.cc, andTransformAsyncIntStreamUntypedProducer.cc, based onTransformAsyncIntStreamProducer.cc.Unless I somehow missed them, it looks like there are currently no equivalent tests for
limitedproducers. If there is no specific reason for this I can add them (both for the typed and for the untyped transformers)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no specific reason for the omission of
limitedproducers in the tests. I'm not asking you to add them, but if you are want to do that, I'd certainly appreciate it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks. I added
TransformIntLimitedProducer.cc,TransformAsyncIntLimitedProducer.cc, andTransformAsyncIntLimitedUntypedProducer.ccplugins, and the same tests for them that we already had forglobalandstreamtransformers.I also moved all test-related changes to a separate commit, if that's ok.